You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2017/08/13 18:46:49 UTC

Review Request 61609: Refactored UPID to be immutable and updated libprocess as necessary.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61609/
-----------------------------------------------------------

Review request for mesos, Avinash sridharan and Benjamin Mahler.


Repository: mesos


Description
-------

UPID has historically been used in a mostly immutable way and with the
recent optimizations that introduced the weak reference to the
underlying `ProcessBase` enforcing this immutability is critical.

This should have the added benefit of improving message passing
performance where the same UPIDs are copied into each `Message` since
we'll simply be copying a `std::shared_ptr`.


Diffs
-----

  3rdparty/libprocess/include/process/pid.hpp 9f09ab46fa3ceaeac09b0fbf9f532728c4ed2d7a 
  3rdparty/libprocess/include/process/system.hpp 21bd3300b104eaa56642f19c3dcb95950ab94830 
  3rdparty/libprocess/src/encoder.hpp 70b5ec479e90c0eb6ac729b465739b581729a956 
  3rdparty/libprocess/src/http.cpp a4d71fb6c345d3c7a7611004830f6c2c0fbf6046 
  3rdparty/libprocess/src/pid.cpp fdc61b5ab6c75b33ce33de7edd11e9302550f300 
  3rdparty/libprocess/src/process.cpp dcd9c6738816764aae066fe56cd5f468c98fc9bd 
  3rdparty/libprocess/src/tests/http_tests.cpp dde05f6a554fcb8c6c89e690bbdcd2bf509854d5 
  3rdparty/libprocess/src/tests/process_tests.cpp 8d36600701a795a7fa8d73a844657ff98eee6aa7 
  3rdparty/libprocess/src/tests/test_linkee.cpp cc482717290f72a5fd95fe745ac01893c0ce41f8 


Diff: https://reviews.apache.org/r/61609/diff/1/


Testing
-------

make check


Thanks,

Benjamin Hindman