You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cassandra.apache.org by Kirk True <ki...@mustardgrain.com> on 2012/06/05 02:24:27 UTC

Quick question on ColumnFamilyStore removeDeleted (related to CASSANDRA-4299)

Hi all,

I'm a bit confused on the ColumnFamilyStore 'remove deleted' methods and 
have a question.

I see this in many callers:

    TODO: this is necessary because when we collate supercolumns
    together, we don't check their subcolumns for relevance, so we need
    to do a second prune post facto here.
    return cf.isSuper() ? removeDeleted(cf, gcBefore) :
    removeDeletedCF(cf, gcBefore);


removeDeleted actually filters out columns and removeDeletedCF doesn't. 
Because "normal" column families only call removeDeletedCF is it assumed 
that deleted and expired columns have already been filtered out? Is that 
what QueryFilter's isRelevant accomplishes?

Thanks,
Kirk

Re: Quick question on ColumnFamilyStore removeDeleted (related to CASSANDRA-4299)

Posted by Sylvain Lebresne <sy...@datastax.com>.

On Tue, Jun 5, 2012 at 2:24 AM, Kirk True <ki...@mustardgrain.com> wrote:
> removeDeleted actually filters out columns and removeDeletedCF doesn't.
> Because "normal" column families only call removeDeletedCF is it assumed
> that deleted and expired columns have already been filtered out? Is that
> what QueryFilter's isRelevant accomplishes?

Yes.

--
Sylvain