Re: Review Request 44524: HIVE-11484 : Fix ObjectInspector for Char and VarChar

[Amareshwari Sriramadasu <am...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44524/#review128339
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On March 30, 2016, 1:43 p.m., Deepak Barr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44524/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 1:43 p.m.)
> 
> 
> Review request for hive and Amareshwari Sriramadasu.
> 
> 
> Bugs: HIVE-11484
>     https://issues.apache.org/jira/browse/HIVE-11484
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Fixed ObjectInspectorConverter and Java ObjectInspector for Char and Varchar
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java 3514726 
>   common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java 969d474 
>   common/src/test/org/apache/hadoop/hive/common/type/TestHiveBaseChar.java 2848465 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java f429709 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java a8e34ff 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 5eb41d5 
>   serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java dd18517 
>   serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java 7d87666 
> 
> Diff: https://reviews.apache.org/r/44524/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>