You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/05/21 06:55:55 UTC

[GitHub] [mynewt-core] sjanc commented on a change in pull request #2550: drivers/da1469x_charger: Enable custom value for NTC

sjanc commented on a change in pull request #2550:
URL: https://github.com/apache/mynewt-core/pull/2550#discussion_r636679568



##########
File path: hw/drivers/chg_ctrl/da1469x_charger/src/da1469x_charger_shell.c
##########
@@ -373,11 +373,53 @@ static const char *const tdie_max[] = {
     NULL,
 };
 
+/*
+ * When pull-up resistor for NTC is different then 15k code needs to
+ * recalculate temperature settings. It uses table with voltages measured
+ * at NTC for values from -10 to 53 deg C and converts voltage to
+ * to values that would be measured IF recommended 15K resistor was used.
+ */
+#if MYNEWT_VAL(DA1469X_CHARGER_NTC_VALUE) != 15000
+static uint16_t Vntc_tab[] = {

Review comment:
       nitpick: could be static const




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org