You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jscheid <gi...@git.apache.org> on 2015/10/21 20:26:14 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-239 disable ttl for STOMP c...
GitHub user jscheid opened a pull request:
https://github.com/apache/activemq-artemis/pull/208
ARTEMIS-239 disable ttl for STOMP connections
Leave dead connection detection up to the heart-beating logic.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/waysact/activemq-artemis ARTEMIS-239-disable-stomp-ttl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #208
----
commit 17cebce5eded62360045788f86e4b940cf062455
Author: Julian Scheid <ju...@gmail.com>
Date: 2015-10-21T18:18:50Z
ARTEMIS-239 disable ttl for STOMP connections
Leave dead connection detection up to the heart-beating logic.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-239 disable ttl for STOMP c...
Posted by jscheid <gi...@git.apache.org>.
Github user jscheid commented on the pull request:
https://github.com/apache/activemq-artemis/pull/208#issuecomment-157861049
We've discussed this more on IRC and it turns out this is a bad idea.
According to the STOMP protocol, the client can ask for no heartbeats (and STOMP 1.0 doesn't support heartbeats at all) and so the server runs in danger of leaking connections when dealing with badly behaved clients when there is no hard upper limit on connection TTL.
We've agreed the correct fix is instead to improve the documentation to point out that TTL needs to be configured correctly on the server to suit the use case, and that clients can't expect long heart beat intervals (or no heart beating at all) to work. Also, it would be good if Artemis could add a mechanism to configure per-acceptor TTL but that is a separate issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-239 disable ttl for STOMP c...
Posted by themerius <gi...@git.apache.org>.
Github user themerius commented on the pull request:
https://github.com/apache/activemq-artemis/pull/208#issuecomment-157843870
Would be nice if this fix goes into the next release of Artemis! Or into the branch, so I can test it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-239 disable ttl for STOMP c...
Posted by jscheid <gi...@git.apache.org>.
Github user jscheid commented on the pull request:
https://github.com/apache/activemq-artemis/pull/208#issuecomment-157060182
Hi @clebertsuconic, is there anything else I can do to move this forward?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-239 disable ttl for STOMP c...
Posted by jscheid <gi...@git.apache.org>.
Github user jscheid closed the pull request at:
https://github.com/apache/activemq-artemis/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-239 disable ttl for STOMP c...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/208#issuecomment-150313180
there is some tests changes I have to do for this...
I will keep this open for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-239 disable ttl for STOMP c...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/pull/208#issuecomment-157844491
@themerius, I'm not sure if @clebertsuconic is done with the test changes, but in any case you can add @jscheid as a git remote and cherry-pick his commit into your own branch for testing purposes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---