[jira] [Commented] (FLINK-8555) Fix TableFunction varargs length exceeds 254 for SQL

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351658#comment-16351658 ] 

ASF GitHub Bot commented on FLINK-8555:
---------------------------------------

GitHub user Xpray opened a pull request:

    https://github.com/apache/flink/pull/5409

    [FLINK-8555][TableAPI & SQL] Fix TableFunction varargs length exceed 254

    
    ## What is the purpose of the change
    
    *Support TableFunction parameters exceeds 254 with Varargs for SQL*
    
    
    ## Brief change log
    
      - *if table function is varargs, do not check max parameter length, set max length to -1*
    
    
    ## Verifying this change
    
    
    
    This change added tests and can be verified as follows:
    
    *(example:)*
      - *SqlITCase.testUDTFWithLongVarargs*
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Xpray/flink FLINK-8555

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5409
    
----
commit 80d8ee3bdfebec4f642d6d543762d426487bf26d
Author: Xpray <le...@...>
Date:   2018-02-04T06:52:27Z

    [FLINK-8555][TableAPI & SQL] Fix TableFunction varargs length exceed 254

----


> Fix TableFunction varargs length exceeds 254 for SQL
> ----------------------------------------------------
>
>                 Key: FLINK-8555
>                 URL: https://issues.apache.org/jira/browse/FLINK-8555
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Major
>
> With Varargs, TableAPI can handle table function call with parameters exceeds 254 correctly.
> This issue is intend to support long parameters for SQL



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)