You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/30 23:02:00 UTC

[jira] [Commented] (HELIX-771) More detailed top state handoff metrics

    [ https://issues.apache.org/jira/browse/HELIX-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669413#comment-16669413 ] 

ASF GitHub Bot commented on HELIX-771:
--------------------------------------

GitHub user zhan849 opened a pull request:

    https://github.com/apache/helix/pull/278

    [HELIX-771] More detailed top state handoff metrics

    
    Added more details about top state handoff to distinguish helix latency and user latency
    
    
    We define there are 2 types of handoff
    - Graceful handoff (controlled top state handoff, i.e. disable instance, load balance, etc)
    - Non-Graceful (uncontroller top state handoff, i.e. node crash, etc)
    
    
    For graceful handoff, we record total handoff latency and user latency
    For non-graceful handoff, we record total handoff only
    
    
    Moved top state handoff metrics to an independent stage to make logics cleaner.\
    Refactored TestTopStateHandoffmetrics to make it cleaner and more json more natively

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhan849/helix harry/topstate-metrics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #278
    
----
commit 7e49f995e29ea200fcc42ce6af148ed521979f5c
Author: Harry Zhang <hr...@...>
Date:   2018-10-30T22:55:20Z

    [HELIX-771] More detailed top state handoff metrics

----


> More detailed top state handoff metrics
> ---------------------------------------
>
>                 Key: HELIX-771
>                 URL: https://issues.apache.org/jira/browse/HELIX-771
>             Project: Apache Helix
>          Issue Type: Bug
>          Components: helix-core
>            Reporter: Harry Zhang
>            Assignee: Harry Zhang
>            Priority: Major
>
> To define top state handoff SLA, we need some more detailed data:
>  * graceful top state handoff (i.e. disable instance / resource / etc, both Helix and e2e latency)
>  * abrupt top state handoff (i.e. node crash)
> AC:
>  - prepare metrics, test, code complete



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)