You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/27 04:47:34 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33070: [SPARK-35551][SQL] Handle the COUNT bug for lateral subqueries

dongjoon-hyun commented on a change in pull request #33070:
URL: https://github.com/apache/spark/pull/33070#discussion_r659261525



##########
File path: sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala
##########
@@ -50,4 +50,6 @@ class AttributeMap[A](val baseMap: Map[ExprId, (Attribute, A)])
   override def iterator: Iterator[(Attribute, A)] = baseMap.valuesIterator
 
   override def -(key: Attribute): Map[Attribute, A] = baseMap.values.toMap - key
+
+  def ++(other: AttributeMap[A]): AttributeMap[A] = new AttributeMap(baseMap ++ other.baseMap)

Review comment:
       This is fixing `src/main/scala-2.12` only. We need to do the same thing for `src/main/scala-2.13`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org