You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/01 09:46:09 UTC
[GitHub] [arrow-datafusion] Dandandan opened a new pull request #806: Simplify inlist 799
Dandandan opened a new pull request #806:
URL: https://github.com/apache/arrow-datafusion/pull/806
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #799
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Speeding up inlist with one or two expressions by converting to a normal boolean expression.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #806: Add optimizer rule to replace inlist with `or` chain for small expression list
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #806:
URL: https://github.com/apache/arrow-datafusion/pull/806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #806: Add optimizer rule to replace inlist with `or` chain for small expression list
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #806:
URL: https://github.com/apache/arrow-datafusion/pull/806#issuecomment-951817309
Marking PRs that haven't had activity in over a month as 'stale-pr' to help me filter the list. Please remove the label or let me know if "stale" is not the correct designation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #806: Add optimizer rule to replace inlist with `or` chain for small expression list
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #806:
URL: https://github.com/apache/arrow-datafusion/pull/806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #806: Add optimizer rule to replace inlist with `or` chain for small expression list
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #806:
URL: https://github.com/apache/arrow-datafusion/pull/806#issuecomment-892128127
I might tune this later at a later moment to be for empty/single items instead for which it really *should* be an improvement, and do some more profiling.
It could also be worse right now because of a slower kernel (how fast is the `or` ATM?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jhorstmann commented on pull request #806: Add optimizer rule to replace inlist with `or` chain for small expression list
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #806:
URL: https://github.com/apache/arrow-datafusion/pull/806#issuecomment-890977100
Cool, this is interesting to me since in our query engine we started from the opposite approach of initially rewriting all IN expressions into comparison and OR and are now introducing specialized kernel for IN. Would be very interested in finding out where the threshold for this optimization is. The benefit is probably bigger for dictionary encoded data and numbers since the string comparison itself will involve some branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #806: Add optimizer rule to replace inlist with `or` chain for small expression list
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #806:
URL: https://github.com/apache/arrow-datafusion/pull/806#issuecomment-890552665
Seems it is not faster (yet). Will do some more research
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #806: Add optimizer rule to replace inlist with `or` chain for small expression list
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #806:
URL: https://github.com/apache/arrow-datafusion/pull/806#issuecomment-958152732
Closing a seemingly stale PR -- please reopen if that was a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #806: Add optimizer rule to replace inlist with `or` chain for small expression list
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #806:
URL: https://github.com/apache/arrow-datafusion/pull/806#issuecomment-958152732
Closing a seemingly stale PR -- please reopen if that was a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #806: Add optimizer rule to replace inlist with `or` chain for small expression list
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #806:
URL: https://github.com/apache/arrow-datafusion/pull/806#issuecomment-892125010
Possibly also related https://github.com/apache/arrow-datafusion/pull/813 as a different performance approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org