[GitHub] [tvm] junrushao commented on pull request #13334: [MetaSchedule] Improve inlining and `VerifyGPUCode` for quantized model workload

[GitBox <gi...@apache.org>]

junrushao commented on PR #13334:
URL: https://github.com/apache/tvm/pull/13334#issuecomment-1309373300

   Hey thanks for the contribution!
   
   I was a bit uncertain if we really want to do name checking to determine constants from the compile engine, because it relies on the assumption that relay exists and relay always use `compile_engine_const` as the constant it introduces, which could be fragile in some certain cases.
   
   There is an alternative I could come up with, and please let me know if it makes sense:
   
   Add a `schedule_rule` attribute here (https://github.com/apache/tvm/blob/fbe174bd6c3054ec480c9551610030bdf2d8b64d/src/relay/backend/te_compiler_cache.cc#L275), which will guide TIR to generate the annotation below:
   
   ```python
   T.block_attr({"schedule_rule": "compute_inline"})
   ```
   
   Then register a PackedFunc `meta_schedule.generic.compute_inline` to apply `compute–inline` as part of the custom schedule rule.
   
   Let me know if it makes sense!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org