You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by jean-frederic clere <jf...@gmail.com> on 2023/06/12 13:33:27 UTC
Re: build trunk in windows
On 5/4/23 11:31, Yann Ylavic wrote:
> On Wed, May 3, 2023 at 2:54 PM jean-frederic clere <jf...@gmail.com> wrote:
>>
>> On 4/24/23 18:25, Steffen wrote:
>>> There is a howto Building Apache and dependencies using CMake at
>>>
>>> https://www.apachelounge.com/viewtopic.php?t=8609
>>> <https://www.apachelounge.com/viewtopic.php?t=8609>
>>>
>>>
>>
>> I ended fixing include/http_protocol.h see patch, did I miss something?
>
> Looks like ap_h1_response_out_filter() is declared in
> "include/mod_core.h" already, but without AP_CORE_DECLARE_NONSTD().
> Not sure if we should remove the AP_CORE_DECLARE_NONSTD() in
> "modules/http/http_filters.c" (where it's implemented) or add it in
> the declaration. For instance ap_http_outerror_filter() has no
> AP_CORE_DECLARE_NONSTD() anywhere..
OK I have fixed ap_h1_response_out_filter() to follow
include/http_protocol.h
>
> Regards;
> Yann.
--
Cheers
Jean-Frederic
Re: build trunk in windows
Posted by Stefan Eissing via dev <de...@httpd.apache.org>.
> Am 12.06.2023 um 15:33 schrieb jean-frederic clere <jf...@gmail.com>:
>
> On 5/4/23 11:31, Yann Ylavic wrote:
>> On Wed, May 3, 2023 at 2:54 PM jean-frederic clere <jf...@gmail.com> wrote:
>>>
>>> On 4/24/23 18:25, Steffen wrote:
>>>> There is a howto Building Apache and dependencies using CMake at
>>>>
>>>> https://www.apachelounge.com/viewtopic.php?t=8609
>>>> <https://www.apachelounge.com/viewtopic.php?t=8609>
>>>>
>>>>
>>>
>>> I ended fixing include/http_protocol.h see patch, did I miss something?
>> Looks like ap_h1_response_out_filter() is declared in
>> "include/mod_core.h" already, but without AP_CORE_DECLARE_NONSTD().
>> Not sure if we should remove the AP_CORE_DECLARE_NONSTD() in
>> "modules/http/http_filters.c" (where it's implemented) or add it in
>> the declaration. For instance ap_http_outerror_filter() has no
>> AP_CORE_DECLARE_NONSTD() anywhere..
>
> OK I have fixed ap_h1_response_out_filter() to follow include/http_protocol.h
\o/
>
>> Regards;
>> Yann.
>
> --
> Cheers
>
> Jean-Frederic
>