You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by BrynCooke <gi...@git.apache.org> on 2017/04/03 11:20:55 UTC
[GitHub] tinkerpop pull request #590: TINKERPOP-1664 StarVertexProperty will check me...
GitHub user BrynCooke opened a pull request:
https://github.com/apache/tinkerpop/pull/590
TINKERPOP-1664 StarVertexProperty will check meta-properties are valid.
StarVertexProperty will check meta-properties are valid.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BrynCooke/incubator-tinkerpop TINKERPOP-1664
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/590.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #590
----
commit 0b05c937ee0b0f9025bd4faf8c101ee3d49a3d62
Author: BrynCooke <br...@gmail.com>
Date: 2017-04-03T11:19:54Z
TINKERPOP-1664
StarVertexProperty will check meta-properties are valid.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #590: TINKERPOP-1664 StarVertexProperty will check me...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/590#discussion_r110167099
--- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/ElementHelper.java ---
@@ -116,6 +116,10 @@ public static void legalPropertyKeyValueArray(final Object... propertyKeyValues)
for (int i = 0; i < propertyKeyValues.length; i = i + 2) {
if (!(propertyKeyValues[i] instanceof String) && !(propertyKeyValues[i] instanceof T))
throw Element.Exceptions.providedKeyValuesMustHaveALegalKeyOnEvenIndices();
+
+ if (propertyKeyValues[i + 1] == null) {
--- End diff --
```
if(null == propertyKeyValues[i+1])
throw Property.Exceptions.propertyValueCanNotBeNull();
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/590
VOTE: +1 - i'll handle the merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #590: TINKERPOP-1664 StarVertexProperty will check me...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/590
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #590: TINKERPOP-1664 StarVertexProperty will check me...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/590#discussion_r109411238
--- Diff: CHANGELOG.asciidoc ---
@@ -64,6 +64,7 @@ TinkerPop 3.2.5 (Release Date: NOT OFFICIALLY RELEASED YET)
* Improved error handling of compilation failures for very large or highly parameterized script sent to Gremlin Server.
* Fixed a bug in `RangeByIsCountStrategy` that changed the meaning of inner traversals.
* Improved Gremlin-Python Driver implementation by adding a threaded client with basic connection pooling and support for pluggable websocket clients.
+* StarVertexProperty will check meta-properties are valid.
--- End diff --
This should be written as:
Fixed a bug in `StarVertexProperty` where properties are now validated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/590
Looks like a candidate for tp31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/590
VOTE: +1
And just like the Java compiler I really don't care whether it's `null == propertyKeyValues[i+1]` or `propertyKeyValues[i+1] == null`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...
Posted by BrynCooke <gi...@git.apache.org>.
Github user BrynCooke commented on the issue:
https://github.com/apache/tinkerpop/pull/590
I've reworked for tp31. Also I check null values on array parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/590
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---