[GitHub] [geode] Bill commented on a diff in pull request #7262: GEODE-6588: Cleanup static analyzer warnings.

[GitBox <gi...@apache.org>]

Bill commented on code in PR #7262:
URL: https://github.com/apache/geode/pull/7262#discussion_r880830479


##########
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientMetadataService.java:
##########
@@ -98,11 +96,13 @@ public ClientMetadataService(Cache cache) {
   private final Map<String, Set<ClientPartitionAdvisor>> colocatedPRAdvisors =
       new ConcurrentHashMap<>();
 
-  private PartitionResolver getResolver(Region r, Object key, Object callbackArgument) {
+  @SuppressWarnings("unchecked")

Review Comment:
   What's the philosophy vis-à-vis `@SuppressWarnings("unchecked")` in this PR? I see how it suppresses the warnings. On the other hand a deeper revision could potentially eliminate the need for the casts TBD.
   
   Is the idea to identify and suppress all the warnings to get to zero warnings so that we can then avoid introducing more, and to then move forward with separate projects to do the work necessary to actually eliminate the casts (and thereby be able to eliminate the annotations entirely)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org