You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zmuxuny (via GitHub)" <gi...@apache.org> on 2026/10/19 13:51:19 UTC
[PR] fix(web): preserve reopened certificate creation drafts [rocketmq-dashboard]
zmuxuny opened a new pull request, #7090:
URL: https://github.com/apache/rocketmq-dashboard/pull/7090
### Which Issue(s) This PR Fixes
Fixes #7087
### Brief Description
A certificate request can finish after its dialog was cancelled and reopened. Its old success handler previously closed the new dialog and erased the operator's unsent draft.
Give each dialog session an identity. A completed request still adds its successfully created certificate to the inventory, but only its owning session may close/reset the form or clear the current pending indicator. Validation that finishes after cancellation is also ignored.
### How Did You Test This Change?
- Fail-before on unchanged `rocketmq-studio@127c47b0`: the real page regression fails because `second-cert` becomes an empty input when the first request resolves.
- `cd web && node node_modules/vitest/vitest.mjs run src/pages/cluster/__tests__/K8sCertsPage.test.tsx --maxWorkers=1 --pool=threads`: **16 tests passed**.
- Deferred-response tests cover the reopened unsent draft, old success/failure while a newer creation is pending, inventory reconciliation, and the newer request's normal completion.
- `tsc -b`, ESLint on the changed files, Prettier, and `git diff --check` passed.
- Independent code review completed.
This is scoped to modal ownership. It does not change server creation semantics, duplicate-submit handling, deletion, or certificate validation. No new UI text or dependencies. No backend/live-cluster test was needed or run. AI assistance was used for implementation, tests, and review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): preserve reopened certificate creation drafts [rocketmq-dashboard]
Posted by "zmuxuny (via GitHub)" <gi...@apache.org>.
zmuxuny commented on PR #7090:
URL: https://github.com/apache/rocketmq-dashboard/pull/7090#issuecomment-6272236006
CI triage for run [39263729537](https://github.com/apache/rocketmq-dashboard/actions/runs/39263729537): backend build, backend tests, frontend Docker build, and rmqctl all passed. The frontend job passed 1,833 tests, including all 16 K8sCertsPage tests; its only failure was the existing ConsumerPage test `highlights inconsistent subscriptions and refreshes the check result`.
I reproduced its known timer/mock race on unchanged production: the modal's 2-second poll can consume the second `mockResolvedValueOnce`, so the subsequent manual refresh uses the default one-subscription response instead of the expected two. Two controlled-timer cases pass: no intervening tick gives two subscriptions/two calls; an intervening tick gives one subscription/three calls and reproduces the original assertion failure. The remote failure's truncated DOM does not directly establish which timer ordering occurred there.
The consumer production/test files are identical between this PR and its base, and this test-only race is already addressed by open #5626. I have kept this certificate fix scoped rather than copying that unrelated change. This account has no rerun control for the upstream workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): preserve reopened certificate creation drafts [rocketmq-dashboard]
Posted by "zmuxuny (via GitHub)" <gi...@apache.org>.
zmuxuny commented on PR #7090:
URL: https://github.com/apache/rocketmq-dashboard/pull/7090#issuecomment-6290240409
Consolidated into #6758, which now covers ownership of instance and certificate creation dialogs, with both original regression sets retained. Closing this separate review; the source branch and discussion are retained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): preserve reopened certificate creation drafts [rocketmq-dashboard]
Posted by "zmuxuny (via GitHub)" <gi...@apache.org>.
zmuxuny closed pull request #7090: fix(web): preserve reopened certificate creation drafts
URL: https://github.com/apache/rocketmq-dashboard/pull/7090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org