You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "xyuanlu (via GitHub)" <gi...@apache.org> on 2023/03/20 23:52:43 UTC
[GitHub] [helix] xyuanlu commented on pull request #2416: Unit test fix - Put clean up in final block in MultiZkTestBase
xyuanlu commented on PR #2416:
URL: https://github.com/apache/helix/pull/2416#issuecomment-1477097945
> LGTM. thanks for fixing this. Can you please check the test failure as it is occuring in: Error: Test failed: testZKHelixManager(org.apache.helix.integration.multizk.TestMultiZkConnectionConfig) Time elapsed: 900.016 s <<< FAILURE! Error: Test failed: afterClass(org.apache.helix.integration.multizk.TestMultiZkConnectionConfig) Time elapsed: 980.144 s <<< FAILURE! Error: Test failed:
Thanks @desaikomal for review. These 2 tests are constantly failing now. Not properly clean up in `TestMultiZkConnectionConfig.afterclass` cause `testZkClientCreationMultiZk` to fail.
This change only fix `testZkClientCreationMultiZk` by properly clean up in afterclass. We still need to root cause the two unit test failure you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org