You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/03 09:13:10 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28108: [SPARK-29154][FOLLOW-UP][CORE] RDD.resourceProfile should not be serialized

HyukjinKwon commented on a change in pull request #28108: [SPARK-29154][FOLLOW-UP][CORE] RDD.resourceProfile should not be serialized
URL: https://github.com/apache/spark/pull/28108#discussion_r402868715
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala
 ##########
 @@ -1747,7 +1747,7 @@ abstract class RDD[T: ClassTag](
   // =======================================================================
 
 Review comment:
   Not related to this PR but shall we remove `@Experimental` and `@Since("3.0.0")` at `getResourceProfile`, `withResources`, etc. (probably in a separate PR)? It's counterintuitive to mark it `private` but annotate it as APIs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org