[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10180: Fix cannot display attached events when using Zipkin Lens UI query traces

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051759903


##########
oap-server/server-query-plugin/zipkin-query-plugin/src/main/java/org/apache/skywalking/oap/query/zipkin/handler/ZipkinQueryHandler.java:
##########
@@ -304,6 +306,16 @@ private byte[] encodeTraces(List<List<Span>> traces) {
         return buff.array();
     }
 
+    private void appendEventsToTraces(List<List<Span>> traces) throws IOException {
+        for (List<Span> spans : traces) {
+            if (CollectionUtils.isEmpty(spans)) {
+                continue;
+            }
+
+            appendEvents(spans, getSpanAttachedEventQueryDAO().querySpanAttachedEvents(SpanAttachedEventTraceType.ZIPKIN, spans.get(0).traceId()));

Review Comment:
   Should consider a list query rather than this.
   10-20 iterations would be very slow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org