You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by Juan Pan <pa...@apache.org> on 2019/11/05 08:11:29 UTC
[VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 2
Hi ShardingSphere Community,
All issues in ROUND 1 have been fixed already, we now kindly request ShardingSphere community to review and vote on this release, i.e Apache ShardingSphere (Incubating) version 4.0.0-RC3.
Release notes:
https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md
The release candidates:
https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/
Maven 2 staging repository:
https://repository.apache.org/content/repositories/orgapacheshardingsphere-1024/org/apache/shardingsphere/
Git tag for the release:
https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/
Release Commit ID:
https://github.com/apache/incubator-shardingsphere/commit/bbeedec206d2e7317159cccff9ce4cafa90f598a
Keys to verify the Release Candidate:
https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS
Look at here for how to verify this release candidate:
https://shardingsphere.apache.org/community/en/contribute/release/
The vote will be open for at least 72 hours or until necessary number of votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Checklist for reference:
[ ] Download links are valid.
[ ] Checksums and PGP signatures are valid.
[ ] DISCLAIMER is included.
[ ] Source code artifacts have correct names matching the current release.
[ ] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[ ] All files have license headers if necessary.
[ ] No compiled archives bundled in source archive.
Best wishes,
Trista
Juan Pan
panjuan@apache.org
Juan Pan(Trista), Apache ShardingSphere
Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 2
Posted by Sheng Wu <wu...@gmail.com>.
Good to know. I think we should ask the release manager to recheck before
release vote mail, in order to avoid the confusion.
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
Juan Pan <pa...@apache.org> 于2019年11月5日周二 下午6:28写道：
> Hi, sorry for that. `node` package is excluded to solve the problem of
> oversized source package in ROUND 1. Therefore you got that exception.
> `source-distribution.xml` will be modified again for this correction.
>
>
> Consequently, I am sorry to tell the community that ROUND 3 is coming
> soon, please wait for it and continue to check and review.
>
>
> Thanks for Sheng's prompt reply to avoid worse result, i will try my best
> to make ROUND 3 go well. :)
>
>
> Best wishes,
> Trista
>
>
> Juan Pan
>
>
> panjuan@apache.org
> Juan Pan(Trista), Apache ShardingSphere
>
>
> On 11/5/2019 17:32，Sheng Wu<wu...@gmail.com> wrote：
> Sorry, still -1.
> The source code compiles failures.
> [*ERROR*] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.3:compile
> *(default-compile)* on project sharding-orchestration-core: *Compilation
> failure*: Compilation failure:
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/AuthenticationChangedListener.java:[24,77]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/service/StateService.java:[21,76]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/service/StateService.java:[32,19]
> 找不到符号
>
> [*ERROR*] 符号: 类 StateNode
>
> [*ERROR*] 位置: 类
>
> org.apache.shardingsphere.orchestration.internal.registry.state.service.StateService
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java:[39,77]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java:[57,19]
> 找不到符号
>
> [*ERROR*] 符号: 类 ConfigurationNode
>
> [*ERROR*] 位置: 类
>
> org.apache.shardingsphere.orchestration.internal.registry.config.service.ConfigurationService
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java:[40,77]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/PropertiesChangedListener.java:[22,77]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java:[63,19]
> 找不到符号
>
> [*ERROR*] 符号: 类 ConfigurationNode
>
> [*ERROR*] 位置: 类
>
> org.apache.shardingsphere.orchestration.internal.registry.config.listener.SchemaChangedListener
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java:[23,76]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java:[24,76]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[22,76]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[23,76]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[37,19]
> 找不到符号
>
> [*ERROR*] 符号: 类 StateNode
>
> [*ERROR*] 位置: 类
>
> org.apache.shardingsphere.orchestration.internal.registry.state.listener.DataSourceStateChangedListener
>
> And when I checked the source,
>
> `sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state`
> in GitHub RC3 tag
> has one more package than your source release tar, which is the missing
> `node`
> folder/package.
>
> I am assuming there are some issues of your source tar package scripts.
>
> And a reminder, the sign mail address is still not Apache's.
>
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
>
>
> Juan Pan <pa...@apache.org> 于2019年11月5日周二 下午4:11写道：
>
> Hi ShardingSphere Community,
>
>
> All issues in ROUND 1 have been fixed already, we now kindly request
> ShardingSphere community to review and vote on this release, i.e Apache
> ShardingSphere (Incubating) version 4.0.0-RC3.
>
>
> Release notes:
>
>
> https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md
>
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/
>
>
> Maven 2 staging repository:
>
>
> https://repository.apache.org/content/repositories/orgapacheshardingsphere-1024/org/apache/shardingsphere/
>
>
> Git tag for the release:
> https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/
>
>
> Release Commit ID:
>
>
> https://github.com/apache/incubator-shardingsphere/commit/bbeedec206d2e7317159cccff9ce4cafa90f598a
>
>
> Keys to verify the Release Candidate:
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS
>
>
> Look at here for how to verify this release candidate:
> https://shardingsphere.apache.org/community/en/contribute/release/
>
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
>
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
> Checklist for reference:
>
>
> [ ] Download links are valid.
>
>
> [ ] Checksums and PGP signatures are valid.
>
>
> [ ] DISCLAIMER is included.
>
>
> [ ] Source code artifacts have correct names matching the current release.
>
>
> [ ] LICENSE and NOTICE files are correct for each ShardingSphere repo.
>
>
> [ ] All files have license headers if necessary.
>
>
> [ ] No compiled archives bundled in source archive.
>
>
>
>
> Best wishes,
> Trista
>
>
> Juan Pan
>
>
> panjuan@apache.org
> Juan Pan(Trista), Apache ShardingSphere
>
>
>
Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3
ROUND 2
Posted by Juan Pan <pa...@apache.org>.
Hi, sorry for that. `node` package is excluded to solve the problem of oversized source package in ROUND 1. Therefore you got that exception. `source-distribution.xml` will be modified again for this correction.
Consequently, I am sorry to tell the community that ROUND 3 is coming soon, please wait for it and continue to check and review.
Thanks for Sheng's prompt reply to avoid worse result, i will try my best to make ROUND 3 go well. :)
Best wishes,
Trista
Juan Pan
panjuan@apache.org
Juan Pan(Trista), Apache ShardingSphere
On 11/5/2019 17:32，Sheng Wu<wu...@gmail.com> wrote：
Sorry, still -1.
The source code compiles failures.
[*ERROR*] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.3:compile
*(default-compile)* on project sharding-orchestration-core: *Compilation
failure*: Compilation failure:
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/AuthenticationChangedListener.java:[24,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/service/StateService.java:[21,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/service/StateService.java:[32,19]
找不到符号
[*ERROR*] 符号: 类 StateNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.state.service.StateService
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java:[39,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java:[57,19]
找不到符号
[*ERROR*] 符号: 类 ConfigurationNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.config.service.ConfigurationService
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java:[40,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/PropertiesChangedListener.java:[22,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java:[63,19]
找不到符号
[*ERROR*] 符号: 类 ConfigurationNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.config.listener.SchemaChangedListener
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java:[23,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java:[24,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[22,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[23,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[37,19]
找不到符号
[*ERROR*] 符号: 类 StateNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.state.listener.DataSourceStateChangedListener
And when I checked the source,
`sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state`
in GitHub RC3 tag
has one more package than your source release tar, which is the missing `node`
folder/package.
I am assuming there are some issues of your source tar package scripts.
And a reminder, the sign mail address is still not Apache's.
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
Juan Pan <pa...@apache.org> 于2019年11月5日周二 下午4:11写道：
Hi ShardingSphere Community,
All issues in ROUND 1 have been fixed already, we now kindly request
ShardingSphere community to review and vote on this release, i.e Apache
ShardingSphere (Incubating) version 4.0.0-RC3.
Release notes:
https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md
The release candidates:
https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/
Maven 2 staging repository:
https://repository.apache.org/content/repositories/orgapacheshardingsphere-1024/org/apache/shardingsphere/
Git tag for the release:
https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/
Release Commit ID:
https://github.com/apache/incubator-shardingsphere/commit/bbeedec206d2e7317159cccff9ce4cafa90f598a
Keys to verify the Release Candidate:
https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS
Look at here for how to verify this release candidate:
https://shardingsphere.apache.org/community/en/contribute/release/
The vote will be open for at least 72 hours or until necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Checklist for reference:
[ ] Download links are valid.
[ ] Checksums and PGP signatures are valid.
[ ] DISCLAIMER is included.
[ ] Source code artifacts have correct names matching the current release.
[ ] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[ ] All files have license headers if necessary.
[ ] No compiled archives bundled in source archive.
Best wishes,
Trista
Juan Pan
panjuan@apache.org
Juan Pan(Trista), Apache ShardingSphere
Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 2
Posted by "zhangliang@apache.org" <zh...@apache.org>.
Because we exclude the folder of node js, and we have same package name is
same name unfortunately.
We will fix this issue soon.
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Juan Pan <pa...@apache.org> 于2019年11月5日周二 下午5:54写道：
> Thanks, i will review it now.
>
>
> Juan Pan
>
>
> panjuan@apache.org
> Juan Pan(Trista), Apache ShardingSphere
>
>
> On 11/5/2019 17:32，Sheng Wu<wu...@gmail.com> wrote：
> Sorry, still -1.
> The source code compiles failures.
> [*ERROR*] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.3:compile
> *(default-compile)* on project sharding-orchestration-core: *Compilation
> failure*: Compilation failure:
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/AuthenticationChangedListener.java:[24,77]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/service/StateService.java:[21,76]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/service/StateService.java:[32,19]
> 找不到符号
>
> [*ERROR*] 符号: 类 StateNode
>
> [*ERROR*] 位置: 类
>
> org.apache.shardingsphere.orchestration.internal.registry.state.service.StateService
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java:[39,77]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java:[57,19]
> 找不到符号
>
> [*ERROR*] 符号: 类 ConfigurationNode
>
> [*ERROR*] 位置: 类
>
> org.apache.shardingsphere.orchestration.internal.registry.config.service.ConfigurationService
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java:[40,77]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/PropertiesChangedListener.java:[22,77]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java:[63,19]
> 找不到符号
>
> [*ERROR*] 符号: 类 ConfigurationNode
>
> [*ERROR*] 位置: 类
>
> org.apache.shardingsphere.orchestration.internal.registry.config.listener.SchemaChangedListener
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java:[23,76]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java:[24,76]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[22,76]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[23,76]
> 程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
>
> [*ERROR*]
>
> /Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[37,19]
> 找不到符号
>
> [*ERROR*] 符号: 类 StateNode
>
> [*ERROR*] 位置: 类
>
> org.apache.shardingsphere.orchestration.internal.registry.state.listener.DataSourceStateChangedListener
>
> And when I checked the source,
>
> `sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state`
> in GitHub RC3 tag
> has one more package than your source release tar, which is the missing
> `node`
> folder/package.
>
> I am assuming there are some issues of your source tar package scripts.
>
> And a reminder, the sign mail address is still not Apache's.
>
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
>
>
> Juan Pan <pa...@apache.org> 于2019年11月5日周二 下午4:11写道：
>
> Hi ShardingSphere Community,
>
>
> All issues in ROUND 1 have been fixed already, we now kindly request
> ShardingSphere community to review and vote on this release, i.e Apache
> ShardingSphere (Incubating) version 4.0.0-RC3.
>
>
> Release notes:
>
>
> https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md
>
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/
>
>
> Maven 2 staging repository:
>
>
> https://repository.apache.org/content/repositories/orgapacheshardingsphere-1024/org/apache/shardingsphere/
>
>
> Git tag for the release:
> https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/
>
>
> Release Commit ID:
>
>
> https://github.com/apache/incubator-shardingsphere/commit/bbeedec206d2e7317159cccff9ce4cafa90f598a
>
>
> Keys to verify the Release Candidate:
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS
>
>
> Look at here for how to verify this release candidate:
> https://shardingsphere.apache.org/community/en/contribute/release/
>
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
>
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
> Checklist for reference:
>
>
> [ ] Download links are valid.
>
>
> [ ] Checksums and PGP signatures are valid.
>
>
> [ ] DISCLAIMER is included.
>
>
> [ ] Source code artifacts have correct names matching the current release.
>
>
> [ ] LICENSE and NOTICE files are correct for each ShardingSphere repo.
>
>
> [ ] All files have license headers if necessary.
>
>
> [ ] No compiled archives bundled in source archive.
>
>
>
>
> Best wishes,
> Trista
>
>
> Juan Pan
>
>
> panjuan@apache.org
> Juan Pan(Trista), Apache ShardingSphere
>
>
>
Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3
ROUND 2
Posted by Juan Pan <pa...@apache.org>.
Thanks, i will review it now.
Juan Pan
panjuan@apache.org
Juan Pan(Trista), Apache ShardingSphere
On 11/5/2019 17:32，Sheng Wu<wu...@gmail.com> wrote：
Sorry, still -1.
The source code compiles failures.
[*ERROR*] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.3:compile
*(default-compile)* on project sharding-orchestration-core: *Compilation
failure*: Compilation failure:
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/AuthenticationChangedListener.java:[24,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/service/StateService.java:[21,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/service/StateService.java:[32,19]
找不到符号
[*ERROR*] 符号: 类 StateNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.state.service.StateService
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java:[39,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java:[57,19]
找不到符号
[*ERROR*] 符号: 类 ConfigurationNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.config.service.ConfigurationService
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java:[40,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/PropertiesChangedListener.java:[22,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java:[63,19]
找不到符号
[*ERROR*] 符号: 类 ConfigurationNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.config.listener.SchemaChangedListener
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java:[23,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java:[24,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[22,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[23,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[37,19]
找不到符号
[*ERROR*] 符号: 类 StateNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.state.listener.DataSourceStateChangedListener
And when I checked the source,
`sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state`
in GitHub RC3 tag
has one more package than your source release tar, which is the missing `node`
folder/package.
I am assuming there are some issues of your source tar package scripts.
And a reminder, the sign mail address is still not Apache's.
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
Juan Pan <pa...@apache.org> 于2019年11月5日周二 下午4:11写道：
Hi ShardingSphere Community,
All issues in ROUND 1 have been fixed already, we now kindly request
ShardingSphere community to review and vote on this release, i.e Apache
ShardingSphere (Incubating) version 4.0.0-RC3.
Release notes:
https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md
The release candidates:
https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/
Maven 2 staging repository:
https://repository.apache.org/content/repositories/orgapacheshardingsphere-1024/org/apache/shardingsphere/
Git tag for the release:
https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/
Release Commit ID:
https://github.com/apache/incubator-shardingsphere/commit/bbeedec206d2e7317159cccff9ce4cafa90f598a
Keys to verify the Release Candidate:
https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS
Look at here for how to verify this release candidate:
https://shardingsphere.apache.org/community/en/contribute/release/
The vote will be open for at least 72 hours or until necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Checklist for reference:
[ ] Download links are valid.
[ ] Checksums and PGP signatures are valid.
[ ] DISCLAIMER is included.
[ ] Source code artifacts have correct names matching the current release.
[ ] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[ ] All files have license headers if necessary.
[ ] No compiled archives bundled in source archive.
Best wishes,
Trista
Juan Pan
panjuan@apache.org
Juan Pan(Trista), Apache ShardingSphere
Re: [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0-RC3 ROUND 2
Posted by Sheng Wu <wu...@gmail.com>.
Sorry, still -1.
The source code compiles failures.
> [*ERROR*] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.3:compile
*(default-compile)* on project sharding-orchestration-core: *Compilation
failure*: Compilation failure:
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/AuthenticationChangedListener.java:[24,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/service/StateService.java:[21,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/service/StateService.java:[32,19]
找不到符号
[*ERROR*] 符号: 类 StateNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.state.service.StateService
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java:[39,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java:[57,19]
找不到符号
[*ERROR*] 符号: 类 ConfigurationNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.config.service.ConfigurationService
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java:[40,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/PropertiesChangedListener.java:[22,77]
程序包org.apache.shardingsphere.orchestration.internal.registry.config.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java:[63,19]
找不到符号
[*ERROR*] 符号: 类 ConfigurationNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.config.listener.SchemaChangedListener
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java:[23,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java:[24,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[22,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[23,76]
程序包org.apache.shardingsphere.orchestration.internal.registry.state.node不存在
[*ERROR*]
/Users/wusheng/Downloads/apache-shardingsphere-incubating-4.0.0-RC3-src-release/sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java:[37,19]
找不到符号
[*ERROR*] 符号: 类 StateNode
[*ERROR*] 位置: 类
org.apache.shardingsphere.orchestration.internal.registry.state.listener.DataSourceStateChangedListener
And when I checked the source,
`sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state`
in GitHub RC3 tag
has one more package than your source release tar, which is the missing `node`
folder/package.
I am assuming there are some issues of your source tar package scripts.
And a reminder, the sign mail address is still not Apache's.
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
Juan Pan <pa...@apache.org> 于2019年11月5日周二 下午4:11写道：
> Hi ShardingSphere Community,
>
>
> All issues in ROUND 1 have been fixed already, we now kindly request
> ShardingSphere community to review and vote on this release, i.e Apache
> ShardingSphere (Incubating) version 4.0.0-RC3.
>
>
> Release notes:
>
> https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md
>
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/
>
>
> Maven 2 staging repository:
>
> https://repository.apache.org/content/repositories/orgapacheshardingsphere-1024/org/apache/shardingsphere/
>
>
> Git tag for the release:
> https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/
>
>
> Release Commit ID:
>
> https://github.com/apache/incubator-shardingsphere/commit/bbeedec206d2e7317159cccff9ce4cafa90f598a
>
>
> Keys to verify the Release Candidate:
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS
>
>
> Look at here for how to verify this release candidate:
> https://shardingsphere.apache.org/community/en/contribute/release/
>
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
>
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
> Checklist for reference:
>
>
> [ ] Download links are valid.
>
>
> [ ] Checksums and PGP signatures are valid.
>
>
> [ ] DISCLAIMER is included.
>
>
> [ ] Source code artifacts have correct names matching the current release.
>
>
> [ ] LICENSE and NOTICE files are correct for each ShardingSphere repo.
>
>
> [ ] All files have license headers if necessary.
>
>
> [ ] No compiled archives bundled in source archive.
>
>
>
>
> Best wishes,
> Trista
>
>
> Juan Pan
>
>
> panjuan@apache.org
> Juan Pan(Trista), Apache ShardingSphere
>
>