You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/20 01:43:02 UTC

[GitHub] [cloudstack] utchoang opened a new pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

utchoang opened a new pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345


   ### Description
   
   Fixes https://github.com/apache/cloudstack/issues/5340
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#discussion_r692912553



##########
File path: ui/src/config/section/compute.js
##########
@@ -181,6 +181,10 @@ export default {
           docHelp: 'adminguide/virtual_machines.html#virtual-machine-snapshots',
           dataView: true,
           popup: true,
+          show: (record) => {
+            return ((['Running'].includes(record.state) && record.hypervisor !== 'LXC') ||

Review comment:
       @rhtyd this is same as line 168 to 169. should be ok.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#issuecomment-902419812


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5345 (SL-JID-541)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#issuecomment-903031085


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#discussion_r692829677



##########
File path: ui/src/config/section/compute.js
##########
@@ -181,6 +181,10 @@ export default {
           docHelp: 'adminguide/virtual_machines.html#virtual-machine-snapshots',
           dataView: true,
           popup: true,
+          show: (record) => {
+            return ((['Running'].includes(record.state) && record.hypervisor !== 'LXC') ||

Review comment:
       @nvazquez @davidjumani @weizhouapache can you review the conditionals? cc @vladimirpetrov @borisstoyanov 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#issuecomment-903031892


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5345 (SL-JID-544)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#issuecomment-902366503


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#issuecomment-903030946


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#issuecomment-902417837


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#issuecomment-902366567


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#issuecomment-902368492


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5345 (SL-JID-538)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#issuecomment-902417916


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#discussion_r692911989



##########
File path: ui/src/config/section/compute.js
##########
@@ -181,6 +181,10 @@ export default {
           docHelp: 'adminguide/virtual_machines.html#virtual-machine-snapshots',
           dataView: true,
           popup: true,
+          show: (record) => {
+            return ((['Running'].includes(record.state) && record.hypervisor !== 'LXC') ||
+              (['Stopped'].includes(record.state) && record.hypervisor !== 'KVM' && record.hypervisor !== 'LXC'))

Review comment:
       small suggestion:
   
   `!['KVM', 'LXC'].includes(record.hypervisor)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5345:
URL: https://github.com/apache/cloudstack/pull/5345#discussion_r692647539



##########
File path: ui/src/config/section/compute.js
##########
@@ -181,6 +181,9 @@ export default {
           docHelp: 'adminguide/virtual_machines.html#virtual-machine-snapshots',
           dataView: true,
           popup: true,
+          show: (record) => {
+            return ((['Running'].includes(record.state) && record.hypervisor !== 'LXC'))

Review comment:
       @utchoang It can still be visible when the VM is stopped and not KVM or LXC
   
   https://github.com/apache/cloudstack/blob/4.15/ui/legacy/scripts/instances.js#L4210




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org