[jira] [Commented] (VCL-985) login page and change locale form use continuations when user is logged out

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439480#comment-15439480 ] 

ASF subversion and git services commented on VCL-985:
-----------------------------------------------------

Commit 1757902 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1757902 ]

VCL-985 - login page and change locale form use continuations when user is logged out

authentication.php: modified printLoginPage: removed hidden input for continuation, added 2 hidden inputs - mode and authtype

states.php: added changeLocale to $actions['entry']

utils.php:
-modified getDojoHTML: added $filename for oneclick section
-modified changeLocale: split into 2 sections, depending on the value of $authed, set $newlocale, $oldmode, and $authtype from continuation if $authed is true, set them from form input variables if $authed is false
-modified getSelectLanguagePulldown: split into 2 sections, depending on the value of $authed, print a select form element based on continuations if $authed is true, print it based on input variables if $authed is false

> login page and change locale form use continuations when user is logged out
> ---------------------------------------------------------------------------
>
>                 Key: VCL-985
>                 URL: https://issues.apache.org/jira/browse/VCL-985
>             Project: VCL
>          Issue Type: Bug
>          Components: web gui (frontend)
>            Reporter: Josh Thompson
>            Assignee: Josh Thompson
>             Fix For: 2.5
>
>
> The form used for changing locale and the login page both use continuations. However, continuations are supposed to be tied to a user. A change was made in the database schema that adds a foreign key to tie the continuations.userid field to the user.id field. For these 2 forms, 0 was being inserted as the userid. This broke with the foreign key constraint. These 2 forms need to be switched to not use continuations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)