You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/12/14 02:12:52 UTC
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2846:
[GOBBLIN-1001] Implement TimePartitionGlobFinder
codecov-io edited a comment on issue #2846: [GOBBLIN-1001] Implement TimePartitionGlobFinder
URL: https://github.com/apache/incubator-gobblin/pull/2846#issuecomment-564186234
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2846?src=pr&el=h1) Report
> Merging [#2846](https://codecov.io/gh/apache/incubator-gobblin/pull/2846?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0a1debc30734ec57d2be7351270894756a6c18af?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `88.33%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2846?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2846 +/- ##
===========================================
+ Coverage 45.59% 45.6% +<.01%
- Complexity 8984 9029 +45
===========================================
Files 1904 1907 +3
Lines 71347 71681 +334
Branches 7876 7900 +24
===========================================
+ Hits 32534 32687 +153
- Misses 35806 35986 +180
- Partials 3007 3008 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2846?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...anagement/dataset/DefaultFileSystemGlobFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvRGVmYXVsdEZpbGVTeXN0ZW1HbG9iRmluZGVyLmphdmE=) | `100% <100%> (+100%)` | `2 <1> (+2)` | :arrow_up: |
| [...ain/java/org/apache/gobblin/time/TimeIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGltZS9UaW1lSXRlcmF0b3IuamF2YQ==) | `63.15% <63.15%> (ø)` | `4 <4> (?)` | |
| [...ta/management/dataset/SimpleFileSystemDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvU2ltcGxlRmlsZVN5c3RlbURhdGFzZXQuamF2YQ==) | `88.88% <88.88%> (ø)` | `4 <4> (?)` | |
| [...ta/management/dataset/TimePartitionGlobFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvVGltZVBhcnRpdGlvbkdsb2JGaW5kZXIuamF2YQ==) | `93.4% <93.4%> (ø)` | `23 <23> (?)` | |
| [...rg/apache/gobblin/salesforce/SalesforceSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZVNvdXJjZS5qYXZh) | `19.81% <0%> (-2.95%)` | `12% <0%> (+1%)` | |
| [...service/modules/orchestration/DagManagerUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXJVdGlscy5qYXZh) | `85.54% <0%> (-1.21%)` | `37% <0%> (ø)` | |
| [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.19% <0%> (-0.07%)` | `2% <0%> (ø)` | |
| [.../gobblin/runtime/CheckpointableWatermarkState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQ2hlY2twb2ludGFibGVXYXRlcm1hcmtTdGF0ZS5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...apache/gobblin/salesforce/SalesforceExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZUV4dHJhY3Rvci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...obblin/salesforce/SalesforceConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZUNvbmZpZ3VyYXRpb25LZXlzLmphdmE=) | | | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2846/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2846?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2846?src=pr&el=footer). Last update [0a1debc...de6c2da](https://codecov.io/gh/apache/incubator-gobblin/pull/2846?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services