You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/10 08:22:23 UTC

[GitHub] [nuttx] XuNeo commented on a diff in pull request #8063: libc/math: add simple implementation for sincos API

XuNeo commented on code in PR #8063:
URL: https://github.com/apache/nuttx/pull/8063#discussion_r1065460966


##########
include/nuttx/lib/math.h:
##########
@@ -394,6 +394,14 @@ long double frexpl(long double x, int *exp);
 
 /* Trigonometric Functions **************************************************/
 
+void        sincosf(float, float *, float *);

Review Comment:
   Is there any reason this one doens't have `FAR` added? `long double modfl (long double x, long double *iptr);`
   Should I add FAR to all pointers in math.h?
   e.g.
   `long double frexpl(long double x, int *exp);`
   `float       nanf(const char *tagp);`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org