You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:52:02 UTC
[GitHub] [lucene-solr] dsmiley opened a new pull request #1703: SOLR-14686: remove SolrCore.logid
dsmiley opened a new pull request #1703:
URL: https://github.com/apache/lucene-solr/pull/1703
Obsoleted by MDC
https://issues.apache.org/jira/browse/SOLR-14686
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1703: SOLR-14686: remove SolrCore.logid
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #1703:
URL: https://github.com/apache/lucene-solr/pull/1703#discussion_r461837562
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -922,20 +920,15 @@ private UpdateHandler createUpdateHandler(String className, UpdateHandler update
return createReloadedUpdateHandler(className, "Update Handler", updateHandler);
}
- public SolrCore(CoreContainer coreContainer, CoreDescriptor cd, ConfigSet configSet) {
- this(coreContainer, cd, configSet, null,
- null, null, null, false);
- }
-
public CoreContainer getCoreContainer() {
return coreContainer;
}
+ SolrCore(CoreContainer coreContainer, CoreDescriptor cd, ConfigSet configSet) {
Review comment:
I just co-located the constructors together, and furthermore reduced the access scope. I could have left this out. The former javadocs were obsoleted recently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley closed pull request #1703: SOLR-14686: remove SolrCore.logid
Posted by GitBox <gi...@apache.org>.
dsmiley closed pull request #1703:
URL: https://github.com/apache/lucene-solr/pull/1703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1703: SOLR-14686: remove SolrCore.logid
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1703:
URL: https://github.com/apache/lucene-solr/pull/1703#issuecomment-1010632734
This PR has been moved and updated: https://github.com/apache/solr/pull/517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org