svn commit: r592980 - /mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java

[tr...@apache.org]

Author: trustin
Date: Wed Nov  7 16:38:56 2007
New Revision: 592980

URL: http://svn.apache.org/viewvc?rev=592980&view=rev
Log:
Removed a unnecessary Runnable class in Executor by merging the run() method into SessionBuffer.

Modified:
    mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java

Modified: mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java?rev=592980&r1=592979&r2=592980&view=diff
==============================================================================
--- mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java (original)
+++ mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java Wed Nov  7 16:38:56 2007
@@ -110,7 +110,7 @@
                         + session.getRemoteAddress());
             }
 
-            getExecutor().execute(new ProcessEventsRunnable(buf));
+            getExecutor().execute(buf);
         }
     }
 
@@ -125,34 +125,25 @@
         }
     }
 
-    private static class SessionBuffer {
+    private class SessionBuffer implements Runnable {
+        
         private final IoSession session;
-
         private final Queue<IoFilterEvent> eventQueue = new CircularQueue<IoFilterEvent>();
-
         private boolean processingCompleted = true;
 
         private SessionBuffer(IoSession session) {
             this.session = session;
         }
-    }
-
-    private class ProcessEventsRunnable implements Runnable {
-        private final SessionBuffer buffer;
-
-        ProcessEventsRunnable(SessionBuffer buffer) {
-            this.buffer = buffer;
-        }
-
+        
         public void run() {
             while (true) {
                 IoFilterEvent event;
 
-                synchronized (buffer.eventQueue) {
-                    event = buffer.eventQueue.poll();
+                synchronized (eventQueue) {
+                    event = eventQueue.poll();
 
                     if (event == null) {
-                        buffer.processingCompleted = true;
+                        processingCompleted = true;
                         break;
                     }
                 }
@@ -162,7 +153,7 @@
 
             if (logger.isDebugEnabled()) {
                 logger.debug("Exiting since queue is empty for "
-                        + buffer.session.getRemoteAddress());
+                        + session.getRemoteAddress());
             }
         }
     }