You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2024/05/14 08:26:35 UTC

[I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

thisisnic opened a new issue, #41647:
URL: https://github.com/apache/arrow/issues/41647

   # Packaging checklist for CRAN release
   
   For a high-level overview of the release process see the
   [Apache Arrow Release Management Guide](https://arrow.apache.org/docs/developers/release.html#post-release-tasks).
   
   cc @jonkeane @amoeba @nealrichardson @assignUser @paleolimbot for coordination on the various tasks to release
   
   ## Before the release candidate is cut
   
   - [x] [Create a GitHub issue](https://github.com/apache/arrow/issues/new/) entitled `[R] CRAN packaging checklist for version X.X.X` and copy this checklist to the issue.
   - [ ] Review deprecated functions to advance their deprecation status, including removing preprocessor directives that no longer apply (search for `ARROW_VERSION_MAJOR` in r/src).
   - [ ] Evaluate the status of any failing [nightly tests and nightly packaging builds](http://crossbow.voltrondata.com). These checks replicate most of the checks that CRAN runs, so we need them all to be passing or to understand that the failures may (though won't necessarily) result in a rejection from CRAN.
   - [ ] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_arrow.html)
   - [ ] Ensure the contents of the README are accurate and up to date.
   - [ ] Run `urlchecker::url_check()` on the R directory at the release candidate.
     commit. Ignore any errors with badges as they will be removed in the CRAN release branch.
   - [ ] [Polish NEWS](https://style.tidyverse.org/news.html#news-release) but do **not** update version numbers (this is done automatically later). You can find commits by, for example, `git log --oneline aa057d0..HEAD | grep "\[R\]"`
   - [ ] Run preliminary reverse dependency checks using `archery docker run r-revdepcheck`.
   - [ ] For major releases, prepare tweet thread highlighting new features.
   
   Wait for the release candidate to be cut:
   
   ## After release candidate has been cut
   
   - [ ] Create a CRAN-release branch from the release candidate commit
   
   ## Prepare and check the .tar.gz that will be released to CRAN.
   
   - [ ] `git fetch upstream && git checkout release-X.X.X-rcXX && git clean -f -d`
   - [ ] Run `make build`. This copies Arrow C++ into tools/cpp, prunes some
     unnecessary components, and runs `R CMD build` to generate the source tarball.
     Because this will install the package, you will need to ensure that the version
     of Arrow C++ available to the configure script is the same as the version
     that is vendored into the R package (e.g., you may need to unset `ARROW_HOME`).
   - [ ] `devtools::check_built("arrow_X.X.X.tar.gz")` locally
   - [ ] Run reverse dependency checks using `archery docker run r-revdepcheck`.
   
   ## Release vote
   
   - [ ] Release vote passed!
   
   ## Generate R package to submit to CRAN
   
   - [ ] If the release candidate commit updated, rebase the CRAN release branch
     on that commit.
   - [ ] Pick any commits that were made to main since the release commit that
     were needed to fix CRAN-related submission issues identified in the above
     steps.
   - [ ] Remove badges from README.md
   - [ ] Run `urlchecker::url_check()` on the R directory
   - [ ] Create a PR entitled `WIP: [R] Verify CRAN release-10.0.1-rc0`. Add
     a comment `@github-actions crossbow submit --group r` to run all R crossbow
     jobs against the CRAN-specific release branch.
   - [ ] Run `Rscript tools/update-checksums.R <libarrow version>` to download the checksums for the pre-compiled binaries from the ASF artifactory into the tools directory.
   - [ ] Regenerate arrow_X.X.X.tar.gz (i.e., `make build`)
   
   Ensure linux binary packages are available:
   - [ ] Ensure linux binaries are available in the artifactory:
     https://apache.jfrog.io/ui/repos/tree/General/arrow/r
   
   ## Check binary Arrow C++ distributions specific to the R package
   
   - [ ] Upload the .tar.gz to [win-builder](https://win-builder.r-project.org/upload.aspx) (r-devel only)
     and confirm (with Nic, who will automatically receive an email about the results) that the check is clean.
     This step cannot be completed before Jeroen has put the binaries in the MinGW repository, i.e. [here](https://ftp.opencpu.org/rtools/ucrt64/), [here](https://ftp.opencpu.org/rtools/mingw64/), and [here](https://ftp.opencpu.org/rtools/mingw32/).
   - [ ] Upload the .tar.gz to [MacBuilder](https://mac.r-project.org/macbuilder/submit.html)
     and confirm that the check is clean
   - [ ] Check `install.packages("arrow_X.X.X.tar.gz")` on Ubuntu and ensure that the
     hosted binaries are used
   - [ ] `devtools::check_built("arrow_X.X.X.tar.gz")` locally one more time (for luck)
   
   ## CRAN submission
   - [ ] Upload arrow_X.X.X.tar.gz to the
     [CRAN submit page](https://xmpalantir.wu.ac.at/cransubmit/)
   - [ ] Confirm the submission email
   
   Wait for CRAN...
   - [ ] Accepted!
   - [ ] Tag the tip of the CRAN-specific release branch
   - [ ] Add a new line to the matrix in the [backwards compatability job](https://github.com/apache/arrow/blob/main/dev/tasks/r/github.linux.arrow.version.back.compat.yml)
   - [ ] (patch releases only) Update the package version in `ci/scripts/PKGBUILD`, `dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb`, `r/DESCRIPTION`, and `r/NEWS.md`
   - [ ] (CRAN-only releases) Rebuild news page with `pkgdown::build_news()` and submit a PR to the asf-site branch of the docs site with the contents of `arrow/r/docs/news/index.html` replacing the current contents of `arrow-site/docs/r/news/index.html`
   - [ ] (CRAN-only releases) Bump the version number in `r/pkgdown/assets/versions.json`, and update this on the [the `asf-site` branch of the docs site](https://github.com/apache/arrow-site) too.
   - [ ] Update the packaging checklist template to reflect any new realities of the
     packaging process.
   - [ ] Wait for CRAN-hosted binaries on the
     [CRAN package page](https://cran.r-project.org/package=arrow) to reflect the
     new version
   - [ ] Tweet!
   
   
   ### Component(s)
   
   R


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123241502

   > Ok, that's an issue: https://www.r-project.org/nosvn/R.check/r-release-windows-x86_64/arrow-00install.html They have turned off network access for the windows build as well.
   
   Let's hope that was just a fluke.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131380033

   I made a [PR](https://github.com/apache/arrow/pull/41830) and cherry-picked it to the maint-16.0.1-r  branch and submitted that to CRAN.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131426584

   Should we move the [r-universe-release tag](https://github.com/apache/arrow/releases/tag/r-universe-release) now, or wait until we actually get to CRAN? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131404185

   > I made a https://github.com/apache/arrow/pull/41830 and cherry-picked those commits to the maint-16.0.1-r branch and submitted that to CRAN.
   
   Thanks Nic, I just got the second email back and the only notes in the auto-check are ones we expect (change in maintainer, and the cpp11 ones that happen to anyone using cpp11).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131587030

   I also just bumped the `r-universe-release` tag to the maintenance branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2117900646

   During the release process that workflow is used to create the binaries that `nixlibs.R` pulls from. So if the mac binaries there are busted we probably want to switch them for working ones. (which requires the PR to be merged and cherry picked on the cran branch so we can build them)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2111341752

   https://github.com/apache/arrow/pull/41629
   
   > I believe this is also causing the builds we are hosting to be slightly busted. I just tried installing a nightly on arm64 and found that gzip wasn't enabled.
   
   This would mean the binaries on jfrog are affected by this. Do we want to replace them? We also still have the issue with the online build on CRAN...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2117940013

   This will need updating to read 16.1.0, then merging & cherry-picking: https://github.com/apache/arrow/pull/41422


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131289104

   I'm trying to replicate those in CI at https://github.com/apache/arrow/pull/41828 looking at https://github.com/r-lib/devtools/issues/2054 though, from Jenny:
   
   > Replace any internal links in your README with a full URL to GitHub (or perhaps a pkgdown site).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2119514983

   I am back on Tuesday and can give it a try then!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2124207368

   I'd like to do the tweet/whatever thread, as I'd like to briefly mention the maintainer change, if that's OK with you @jonkeane?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123232854

   crossbow jobs from r-release branch: https://github.com/apache/arrow/pull/41762


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2127677086

   Re: revdepchecks, I wanted a reason to try out https://github.com/r-devel/recheck so I kicked off https://github.com/amoeba/arrow-r-recheck/actions/runs/9212033245.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131286170

   Those possibly invalid URIs look like they were introduced in https://github.com/apache/arrow/pull/40148 (and so this is the first CRAN submission with them here)
   
   I'm a little surprised that we don't see them in our as-cran check though: https://github.com/ursacomputing/crossbow/actions/runs/9231423983/job/25401288490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123573814

   I have tagged the cran commit for 15.0.1. ~~I also merged #41629 and picked it into the release branch~~ (I have dropped that again as it was just affecting the actual nightly package binary not the libarrow binaries) and removed the badges and added the checksums
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2119715520

   > I am back on Tuesday and can give it a try then!
   
   Fantastic, thanks! Do you reckon you'll have time after that to make it into a Dockerfile like we chatted about a while ago? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131380960

   @assignUser Did we fix the binaries you mentioned earlier? I noticed the checksums were updated on the branch a few days ago so wasn't sure if it was that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131914998

   > Keen to hear what other folks think though, there may be good reasons to hang back.
   
   👍 I thought about bumping it when I created the branch but it seemed to early as we were missing the news still, but tagging it once we are release ready (regardless if on cran or not) seems like a good point  to do it :)
   
   Looks like the build is failing in the actual package build on oldrel intel with no actual error visible... I'll try to replicate on gha.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123595177

   Crossbow jobs look good, the only thing left imo is to update and merge https://github.com/apache/arrow/pull/41422 and then the submission process (+maintainer change). I think we should pro-actively ask about the offline build stuff especially now that it also happens on windows (but I'll leave that up to @jonkeane  :) ). 
   
   The non-api calls are from cpp11 afaiu? Also it seems those where converted to a note from an error?
   
   That's as far as I can contribute for now, good luck!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2113707760

   Thanks for starting this off @thisisnic. I noticed that https://github.com/apache/arrow/issues/40388 is still open and I think at least one or two things are still undone (tagging commit for cran submission, update backwards compat job). Do you remember which commit we sent off to CRAN?
   
   > We also still have the issue with the offline build on CRAN...
   
   Do we have an issue with next steps? Is this what caused the Mac build to be disabled?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2128031036

   I think the recheck output looks clear but would appreciate another set of eyes. I ran it from the `maint-16.1.0-r` branch and triggered revdepcheck for [strong](https://github.com/amoeba/arrow-r-recheck/actions/runs/9212033245) (depends/imports) and [most](https://github.com/amoeba/arrow-r-recheck/actions/runs/9212446862) (depends/imports/suggests). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2127648238

   @paleolimbot How are the revdepchecks looking?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2145714373

   I pushed both tags `r-16.1.0` and `r-universe-release`.  We should add the latter to our checklist.
   We should also add a link to [Bryce's script for the contributor calculation](https://gist.githubusercontent.com/amoeba/4e26c064d1a0d0227cd8c2260cf0072a/raw/bc0d983152bdde4820de9074d4caee9986624bc5/new_contributors.R) for the social media thread.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2117849297

   @assignUser The issue you linked to, has that ended up just being a CI issue so doesn't affect the release?  And can you elaborate on the Jfrog binaries issue, I don't understand exactly what's going on there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2128274687

   > Let's hope that was just a fluke.
   
   Looks like it was, the windows check is fine again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2129467015

   Thanks @amoeba for the reverse dependency check...I'm not sure I ever would have thought of that solution and it is a lot easier than anything I was planning to try!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131948195

   I was of course unable to reproduce, there are a bunch of warnings which I assume to be env specific or they would have shown up on cran as well https://github.com/assignUser/test-repo-a/actions/runs/9239685590/job/25419135479#step:3:552


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131808044

   Thanks for doing the r-universe tag @jonkeane, we should add that to our release checklist. 
   
   IMO we should just tag it for r-universe when we have done the various steps to submit to CRAN as we can move it later if necessary, and at that point we are confident enough about the package that any changes needed are very CRAN-oriented rather than release-specific. Keen to hear what other folks think though, there may be good reasons to hang back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2124201986

   Thanks @assignUser for your hard work!  Once we're ready to submit to CRAN, I'll email about the maintainer change.
   
   The plan regarding the builds is to submit the package, see what happens, and then if we get a hobbled build, then immediately get onto emailing CRAN and/or the dev mailing list.  I'd like the maintainer change to happen before we do that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123238061

   Ok, that's an issue: https://www.r-project.org/nosvn/R.check/r-release-windows-x86_64/arrow-00install.html
   They have turned off network access for the windows build as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131284836

   Nic submitted the package and I've confirmed.
   
   I just got the (automated, pre-test email that flagged Notes in two builds) https://win-builder.r-project.org/incoming_pretest/arrow_16.1.0_20240525_151425/Windows/00check.log https://win-builder.r-project.org/incoming_pretest/arrow_16.1.0_20240525_151425/Debian/00check.log
   
   For both of these:
   One NOTE is the maintainer change (which we know about)
   ```
   * checking CRAN incoming feasibility ... [5s/7s] NOTE
   Maintainer: ‘Jonathan Keane <jk...@gmail.com>’
   
   New maintainer:
     Jonathan Keane <jk...@gmail.com>
   Old maintainer(s):
     Nic Crane <th...@gmail.com>
   ```
   
   One NOTE is the so-called non-API calls.
   
   ```
   * checking compiled code ... NOTE
   File ‘arrow/libs/arrow.so’:
     Found non-API calls to R: ‘SETLENGTH’, ‘SET_TRUELENGTH’
   
   Compiled code should not call non-API entry points in R.
   ```
   
   I believe these are "ok" because other packages with cpp11 dependencies (e.g. [systemfonts](https://cran.r-project.org/web/checks/check_results_systemfonts.html)) have been submitted and passed with these.
   
   
   One other thing that's _slightly_ more worrying is:
   
   ```
   Found the following (possibly) invalid file URIs:
     URI: articles/read_write.html
       From: README.md
     URI: articles/data_wrangling.html
       From: README.md
     URI: reference/acero.html
       From: README.md
     URI: articles/install.html
       From: README.md
     URI: articles/install_nightly.html
       From: README.md
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131573979

   > arrow_16.1.0.tar.gz is on its way to CRAN.
   
   Also up at https://cran.r-project.org/web/packages/arrow/index.html
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2145731289

   We should also remove the text which refer to previous steps which Jeroen did as I got tripped up skim-reading and not realising the steps were still valid even if those bits aren't any more


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2117908559

   Right, sounds like we probably want to fix it then


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser closed issue #41647: [R] CRAN packaging checklist for version 16.1.0
URL: https://github.com/apache/arrow/issues/41647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2132575287

   but also:
   ```
   Arrow package version: 16.1.0
   
   Capabilities:
   
   acero      TRUE
   dataset    TRUE
   substrait FALSE
   parquet    TRUE
   json       TRUE
   s3        FALSE
   gcs       FALSE
   utf8proc   TRUE
   re2        TRUE
   snappy     TRUE
   gzip      FALSE
   brotli    FALSE
   zstd      FALSE
   lz4        TRUE
   lz4_frame  TRUE
   lzo       FALSE
   bz2       FALSE
   jemalloc  FALSE
   mimalloc   TRUE
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2132573195

   And the error is gone again? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131382177

   Yes that's fine, it was only affecting the actual nightly package binaries not the libarrow binaries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2131409889

   And thank you everyone for y'alls help here 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2117942060

   @paleolimbot Would you mind doing the revdepcheck pls?  I haven't created an R-specific branch but I don't think we need to cherry-pick anything over that is code, so the main release branch should be good to use.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2117838792

   Thanks for flagging this up @amoeba! In terms of the commit, it should be the one at the head of the relevant release branch.
   I think we need to discuss this with CRAN perhaps, depending on whether it works or not upon the next release.  Pinging @jonkeane who had a better idea.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123250635

   I am going to upload a tarball to winbuilder (though it passing there doesn't really mean anything)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [R] CRAN packaging checklist for version 16.1.0 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #41647:
URL: https://github.com/apache/arrow/issues/41647#issuecomment-2123294665

   As expected win builder passed...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org