[GitHub] [ozone] GeorgeJahad commented on pull request #4571: HDDS-8207. [Snapshot] Add tests for SnapshotDeletingService.

["GeorgeJahad (via GitHub)" <gi...@apache.org>]

GeorgeJahad commented on PR #4571:
URL: https://github.com/apache/ozone/pull/4571#issuecomment-1515504846

   It looks like **checkDirReclaimable()** returns **true** if the dir is reclaimable, but **checkKeyReclaimable()** returns **false** if the key is reclaimable.  Is that correct?
   
   https://github.com/apache/ozone/blob/9cd92f4f24791a7e794c64fa641b53e2bbd4412e/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java#L452-L459
   
   
   https://github.com/apache/ozone/blob/9cd92f4f24791a7e794c64fa641b53e2bbd4412e/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java#L474-L485
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org