You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/24 17:31:40 UTC

[GitHub] [skywalking] dominicqi opened a new issue #4709: Snapshot continued NullPointerException

dominicqi opened a new issue #4709:
URL: https://github.com/apache/skywalking/issues/4709


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [-] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happen?
   
   ContextManager#continued remove valid about IgnoredTraceContext.
   
   https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java#L143
   
   Here will throw NullPointerException  if the pre-TraceContext is  IgnoredContext.
   
   https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextSnapshot.java#L53
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.
     should allow IgnoredTraceContext continue 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #4709: Snapshot continued NullPointerException

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4709:
URL: https://github.com/apache/skywalking/issues/4709#issuecomment-619279788


   @mrproliu please take a look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org