You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Arya Goudarzi (JIRA)" <ji...@apache.org> on 2010/06/11 01:05:13 UTC

[jira] Created: (CASSANDRA-1180) read_repair_chance is missing from CfDef

read_repair_chance is missing from CfDef
----------------------------------------

                 Key: CASSANDRA-1180
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.7
            Reporter: Arya Goudarzi


CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1180) read_repair_chance is missing from CfDef

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1180:
-------------------------------------

    Attachment:     (was: 0001-add-read_repair_chance-to-CfDef.patch)

> read_repair_chance is missing from CfDef
> ----------------------------------------
>
>                 Key: CASSANDRA-1180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Arya Goudarzi
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-add-read_repair_chance-to-CfDef.patch, 0002-avoid-constructor-proliferation-in-CFM.patch
>
>
> CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1180) read_repair_chance is missing from CfDef

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878989#action_12878989 ] 

Jonathan Ellis commented on CASSANDRA-1180:
-------------------------------------------

+1 latest

> read_repair_chance is missing from CfDef
> ----------------------------------------
>
>                 Key: CASSANDRA-1180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Arya Goudarzi
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-add-read_repair_chance-to-CfDef.patch, 0002-avoid-constructor-proliferation-in-CFM.patch
>
>
> CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-1180) read_repair_chance is missing from CfDef

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek resolved CASSANDRA-1180.
--------------------------------------

    Resolution: Not A Problem

Looks like this was taken care of on 2 April as part of CASSANDRA-930

> read_repair_chance is missing from CfDef
> ----------------------------------------
>
>                 Key: CASSANDRA-1180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Arya Goudarzi
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>
> CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1180) read_repair_chance is missing from CfDef

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1180:
--------------------------------------

    Fix Version/s: 0.7
         Priority: Minor  (was: Major)

> read_repair_chance is missing from CfDef
> ----------------------------------------
>
>                 Key: CASSANDRA-1180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Arya Goudarzi
>            Priority: Minor
>             Fix For: 0.7
>
>
> CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1180) read_repair_chance is missing from CfDef

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1180:
-------------------------------------

    Attachment: 0001-add-read_repair_chance-to-CfDef.patch
                0002-avoid-constructor-proliferation-in-CFM.patch

> read_repair_chance is missing from CfDef
> ----------------------------------------
>
>                 Key: CASSANDRA-1180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Arya Goudarzi
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-add-read_repair_chance-to-CfDef.patch, 0002-avoid-constructor-proliferation-in-CFM.patch
>
>
> CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (CASSANDRA-1180) read_repair_chance is missing from CfDef

Posted by "Arya Goudarzi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arya Goudarzi reopened CASSANDRA-1180:
--------------------------------------


Hi Gary,

The patch in the bug you've mentioned above contains only changes to Java StorageProxy, CFMetaData, and DatabaseDescriptor. However it does not include changes to Interface/cassandra.thrift as of today's trunc. It reads:

/* describes a column family. */
struct CfDef {
    1: required string table,
    2: required string name,
    3: optional string column_type="Standard",
    4: optional string clock_type="Timestamp",
    5: optional string comparator_type="BytesType",
    6: optional string subcomparator_type="",
    7: optional string reconciler="",
    8: optional string comment="",
    9: optional double row_cache_size=0,
    10: optional bool preload_row_cache=0,
    11: optional double key_cache_size=200000
}

Missing read_repair_chance which makes dynamic creation of CFs using the Thrift API to miss that configuration value. My apologies if my original description was not so clear.

> read_repair_chance is missing from CfDef
> ----------------------------------------
>
>                 Key: CASSANDRA-1180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Arya Goudarzi
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>
> CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1180) read_repair_chance is missing from CfDef

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878970#action_12878970 ] 

Jonathan Ellis commented on CASSANDRA-1180:
-------------------------------------------

don't we need some logic to connect the CfDef field with CFMetaData?

> read_repair_chance is missing from CfDef
> ----------------------------------------
>
>                 Key: CASSANDRA-1180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Arya Goudarzi
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-add-read_repair_chance-to-CfDef.patch
>
>
> CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CASSANDRA-1180) read_repair_chance is missing from CfDef

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek reassigned CASSANDRA-1180:
----------------------------------------

    Assignee: Gary Dusbabek

> read_repair_chance is missing from CfDef
> ----------------------------------------
>
>                 Key: CASSANDRA-1180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Arya Goudarzi
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>
> CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1180) read_repair_chance is missing from CfDef

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878980#action_12878980 ] 

Gary Dusbabek commented on CASSANDRA-1180:
------------------------------------------

jbellis: oops.  fixed.  The second patch cleans up the constructors in CFMetadata.

> read_repair_chance is missing from CfDef
> ----------------------------------------
>
>                 Key: CASSANDRA-1180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Arya Goudarzi
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-add-read_repair_chance-to-CfDef.patch, 0002-avoid-constructor-proliferation-in-CFM.patch
>
>
> CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1180) read_repair_chance is missing from CfDef

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1180:
-------------------------------------

    Attachment: 0001-add-read_repair_chance-to-CfDef.patch

> read_repair_chance is missing from CfDef
> ----------------------------------------
>
>                 Key: CASSANDRA-1180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Arya Goudarzi
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-add-read_repair_chance-to-CfDef.patch
>
>
> CfDef is missing read_repair_chance if that is going to remain a configuration option in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.