You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Andrew Wang (JIRA)" <ji...@apache.org> on 2014/05/03 03:41:15 UTC

[jira] [Commented] (HDFS-6298) XML based End-to-End test for getfattr and setfattr commands

    [ https://issues.apache.org/jira/browse/HDFS-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988519#comment-13988519 ] 

Andrew Wang commented on HDFS-6298:
-----------------------------------

Hi Yi, thanks for the patch. A few review comments:

* Let's restore System.err in an @After clause in TestXAttrCommands. The System.err stuff could be done in a @BeforeClass and @AfterClass if you want. We should reset errContent in an @After too.
* Higher-level comment, is TestXAttrCommands even necessary when we have the XML infrastructure? It seems like we could fold those into the XML test instead.
* Maybe add tests for removing/getting a non-existent xattr, help commands?

+1 once addressed.

> XML based End-to-End test for getfattr and setfattr commands
> ------------------------------------------------------------
>
>                 Key: HDFS-6298
>                 URL: https://issues.apache.org/jira/browse/HDFS-6298
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Uma Maheswara Rao G
>            Assignee: Yi Liu
>             Fix For: HDFS XAttrs (HDFS-2006)
>
>         Attachments: HDFS-6298.patch
>
>
> This JIRA to add test cases with CLI



--
This message was sent by Atlassian JIRA
(v6.2#6252)