You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Pavitra Subramaniam (JIRA)" <de...@myfaces.apache.org> on 2009/12/17 00:49:18 UTC
[jira] Created: (TRINIDAD-1659) Maven 2.0 plugin needs to add
support for the new JSF 2.0 faces-config element
element
Maven 2.0 plugin needs to add support for the new JSF 2.0 faces-config element <partial-view-context-factory> element
---------------------------------------------------------------------------------------------------------------------
Key: TRINIDAD-1659
URL: https://issues.apache.org/jira/browse/TRINIDAD-1659
Project: MyFaces Trinidad
Issue Type: New Feature
Components: Plugins
Affects Versions: 2.0.0-plugins
Environment: Windows XP / JSF 2.0
Reporter: Pavitra Subramaniam
1. When tryjng to register a new factory - PartialViewContextFactory - in faces-config-base.xml in trinidad-impl, I noticed that the generated faces-config.xml did not have the factory element I added. It should look like this (see last element)
<factory>
<faces-context-factory>org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl</faces-context-factory>
<render-kit-factory>org.apache.myfaces.trinidadinternal.renderkit.CoreRenderKitFactory</render-kit-factory>
<partial-view-context-factory>org.apache.myfaces.trinidadinternal.context.PartialViewContextFactoryImpl</partial-view-context-factory>
</factory>
2. Turns out the transform20.xsl used to parse and generate the faces-config was not looking for this new element. Code changes were required in transform20.xsl (maven-faces-plugin\src\main\resources\org\apache\myfaces\trinidadbuild\plugin\faces\resources)
3. Making the necessary updates in the file, compiling and using the plugin JARS to build trinidad, worked. AS in the generated faces-config.xml did contain the entry I added for the <partial-view-context-factory>
4. See attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (TRINIDAD-1659) Maven 2.0 plugin needs to add
support for the new JSF 2.0 faces-config element
element
Posted by Matthias Wessendorf <ma...@apache.org>.
http://svn.apache.org/viewvc?view=revision&revision=891581
On Thu, Dec 17, 2009 at 8:16 AM, Matthias Wessendorf <ma...@apache.org> wrote:
> good catch :-) Will submit your patch later 2day.
>
> -M
>
> On Thu, Dec 17, 2009 at 1:07 AM, Pavitra Subramaniam
> <pa...@oracle.com> wrote:
>> Hi,
>>
>> I have uploaded a patch for the Maven 2.0 plugins to recognize the new
>> element "<partial-view-context-factory>" that can be added to the
>> <faces-config> ...<factory> element. The faces-config.xsd can be found here
>> - http://java.sun.com/xml/ns/javaee/web-facesconfig_2_0.xsd
>>
>> For details please refer to the issue.
>>
>> If the changes look ok, I would like to commit this patch.
>>
>> Thanks
>> Pavitra
>>
>>
>>
>> "Pavitra Subramaniam (JIRA) wrote:" On 12/16/2009 3:51 PM PT:
>>>
>>> [
>>> https://issues.apache.org/jira/browse/TRINIDAD-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>> ]
>>>
>>> Pavitra Subramaniam updated TRINIDAD-1659:
>>> ------------------------------------------
>>>
>>> Status: Patch Available (was: Open)
>>>
>>>
>>>>
>>>> Maven 2.0 plugin needs to add support for the new JSF 2.0 faces-config
>>>> element <partial-view-context-factory> element
>>>>
>>>> ---------------------------------------------------------------------------------------------------------------------
>>>>
>>>> Key: TRINIDAD-1659
>>>> URL: https://issues.apache.org/jira/browse/TRINIDAD-1659
>>>> Project: MyFaces Trinidad
>>>> Issue Type: New Feature
>>>> Components: Plugins
>>>> Affects Versions: 2.0.0-plugins
>>>> Environment: Windows XP / JSF 2.0
>>>> Reporter: Pavitra Subramaniam
>>>>
>>>> 1. When tryjng to register a new factory - PartialViewContextFactory - in
>>>> faces-config-base.xml in trinidad-impl, I noticed that the generated
>>>> faces-config.xml did not have the factory element I added. It should look
>>>> like this (see last element)
>>>> <factory>
>>>>
>>>> <faces-context-factory>org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl</faces-context-factory>
>>>>
>>>> <render-kit-factory>org.apache.myfaces.trinidadinternal.renderkit.CoreRenderKitFactory</render-kit-factory>
>>>>
>>>> <partial-view-context-factory>org.apache.myfaces.trinidadinternal.context.PartialViewContextFactoryImpl</partial-view-context-factory>
>>>> </factory>
>>>> 2. Turns out the transform20.xsl used to parse and generate the
>>>> faces-config was not looking for this new element. Code changes were
>>>> required in transform20.xsl
>>>> (maven-faces-plugin\src\main\resources\org\apache\myfaces\trinidadbuild\plugin\faces\resources)
>>>> 3. Making the necessary updates in the file, compiling and using the
>>>> plugin JARS to build trinidad, worked. AS in the generated faces-config.xml
>>>> did contain the entry I added for the <partial-view-context-factory>
>>>> 4. See attached patch
>>>>
>>>
>>>
>>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: [jira] Updated: (TRINIDAD-1659) Maven 2.0 plugin needs to add
support for the new JSF 2.0 faces-config element
element
Posted by Matthias Wessendorf <ma...@apache.org>.
good catch :-) Will submit your patch later 2day.
-M
On Thu, Dec 17, 2009 at 1:07 AM, Pavitra Subramaniam
<pa...@oracle.com> wrote:
> Hi,
>
> I have uploaded a patch for the Maven 2.0 plugins to recognize the new
> element "<partial-view-context-factory>" that can be added to the
> <faces-config> ...<factory> element. The faces-config.xsd can be found here
> - http://java.sun.com/xml/ns/javaee/web-facesconfig_2_0.xsd
>
> For details please refer to the issue.
>
> If the changes look ok, I would like to commit this patch.
>
> Thanks
> Pavitra
>
>
>
> "Pavitra Subramaniam (JIRA) wrote:" On 12/16/2009 3:51 PM PT:
>>
>> [
>> https://issues.apache.org/jira/browse/TRINIDAD-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Pavitra Subramaniam updated TRINIDAD-1659:
>> ------------------------------------------
>>
>> Status: Patch Available (was: Open)
>>
>>
>>>
>>> Maven 2.0 plugin needs to add support for the new JSF 2.0 faces-config
>>> element <partial-view-context-factory> element
>>>
>>> ---------------------------------------------------------------------------------------------------------------------
>>>
>>> Key: TRINIDAD-1659
>>> URL: https://issues.apache.org/jira/browse/TRINIDAD-1659
>>> Project: MyFaces Trinidad
>>> Issue Type: New Feature
>>> Components: Plugins
>>> Affects Versions: 2.0.0-plugins
>>> Environment: Windows XP / JSF 2.0
>>> Reporter: Pavitra Subramaniam
>>>
>>> 1. When tryjng to register a new factory - PartialViewContextFactory - in
>>> faces-config-base.xml in trinidad-impl, I noticed that the generated
>>> faces-config.xml did not have the factory element I added. It should look
>>> like this (see last element)
>>> <factory>
>>>
>>> <faces-context-factory>org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl</faces-context-factory>
>>>
>>> <render-kit-factory>org.apache.myfaces.trinidadinternal.renderkit.CoreRenderKitFactory</render-kit-factory>
>>>
>>> <partial-view-context-factory>org.apache.myfaces.trinidadinternal.context.PartialViewContextFactoryImpl</partial-view-context-factory>
>>> </factory>
>>> 2. Turns out the transform20.xsl used to parse and generate the
>>> faces-config was not looking for this new element. Code changes were
>>> required in transform20.xsl
>>> (maven-faces-plugin\src\main\resources\org\apache\myfaces\trinidadbuild\plugin\faces\resources)
>>> 3. Making the necessary updates in the file, compiling and using the
>>> plugin JARS to build trinidad, worked. AS in the generated faces-config.xml
>>> did contain the entry I added for the <partial-view-context-factory>
>>> 4. See attached patch
>>>
>>
>>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: [jira] Updated: (TRINIDAD-1659) Maven 2.0 plugin needs to add
support for the new JSF 2.0 faces-config element
element
Posted by Pavitra Subramaniam <pa...@oracle.com>.
Hi,
I have uploaded a patch for the Maven 2.0 plugins to recognize the new
element "<partial-view-context-factory>" that can be added to the
<faces-config> ...<factory> element. The faces-config.xsd can be found
here - http://java.sun.com/xml/ns/javaee/web-facesconfig_2_0.xsd
For details please refer to the issue.
If the changes look ok, I would like to commit this patch.
Thanks
Pavitra
"Pavitra Subramaniam (JIRA) wrote:" On 12/16/2009 3:51 PM PT:
> [ https://issues.apache.org/jira/browse/TRINIDAD-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Pavitra Subramaniam updated TRINIDAD-1659:
> ------------------------------------------
>
> Status: Patch Available (was: Open)
>
>
>> Maven 2.0 plugin needs to add support for the new JSF 2.0 faces-config element <partial-view-context-factory> element
>> ---------------------------------------------------------------------------------------------------------------------
>>
>> Key: TRINIDAD-1659
>> URL: https://issues.apache.org/jira/browse/TRINIDAD-1659
>> Project: MyFaces Trinidad
>> Issue Type: New Feature
>> Components: Plugins
>> Affects Versions: 2.0.0-plugins
>> Environment: Windows XP / JSF 2.0
>> Reporter: Pavitra Subramaniam
>>
>> 1. When tryjng to register a new factory - PartialViewContextFactory - in faces-config-base.xml in trinidad-impl, I noticed that the generated faces-config.xml did not have the factory element I added. It should look like this (see last element)
>> <factory>
>> <faces-context-factory>org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl</faces-context-factory>
>> <render-kit-factory>org.apache.myfaces.trinidadinternal.renderkit.CoreRenderKitFactory</render-kit-factory>
>> <partial-view-context-factory>org.apache.myfaces.trinidadinternal.context.PartialViewContextFactoryImpl</partial-view-context-factory>
>> </factory>
>> 2. Turns out the transform20.xsl used to parse and generate the faces-config was not looking for this new element. Code changes were required in transform20.xsl (maven-faces-plugin\src\main\resources\org\apache\myfaces\trinidadbuild\plugin\faces\resources)
>> 3. Making the necessary updates in the file, compiling and using the plugin JARS to build trinidad, worked. AS in the generated faces-config.xml did contain the entry I added for the <partial-view-context-factory>
>> 4. See attached patch
>>
>
>
[jira] Updated: (TRINIDAD-1659) Maven 2.0 plugin needs to add
support for the new JSF 2.0 faces-config element
element
Posted by "Pavitra Subramaniam (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavitra Subramaniam updated TRINIDAD-1659:
------------------------------------------
Status: Patch Available (was: Open)
> Maven 2.0 plugin needs to add support for the new JSF 2.0 faces-config element <partial-view-context-factory> element
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1659
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1659
> Project: MyFaces Trinidad
> Issue Type: New Feature
> Components: Plugins
> Affects Versions: 2.0.0-plugins
> Environment: Windows XP / JSF 2.0
> Reporter: Pavitra Subramaniam
>
> 1. When tryjng to register a new factory - PartialViewContextFactory - in faces-config-base.xml in trinidad-impl, I noticed that the generated faces-config.xml did not have the factory element I added. It should look like this (see last element)
> <factory>
> <faces-context-factory>org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl</faces-context-factory>
> <render-kit-factory>org.apache.myfaces.trinidadinternal.renderkit.CoreRenderKitFactory</render-kit-factory>
> <partial-view-context-factory>org.apache.myfaces.trinidadinternal.context.PartialViewContextFactoryImpl</partial-view-context-factory>
> </factory>
> 2. Turns out the transform20.xsl used to parse and generate the faces-config was not looking for this new element. Code changes were required in transform20.xsl (maven-faces-plugin\src\main\resources\org\apache\myfaces\trinidadbuild\plugin\faces\resources)
> 3. Making the necessary updates in the file, compiling and using the plugin JARS to build trinidad, worked. AS in the generated faces-config.xml did contain the entry I added for the <partial-view-context-factory>
> 4. See attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1659) Maven 2.0 plugin needs to add
support for the new JSF 2.0 faces-config element
element
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated TRINIDAD-1659:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-plugins
Assignee: Matthias Weßendorf
Status: Resolved (was: Patch Available)
> Maven 2.0 plugin needs to add support for the new JSF 2.0 faces-config element <partial-view-context-factory> element
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1659
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1659
> Project: MyFaces Trinidad
> Issue Type: New Feature
> Components: Plugins
> Affects Versions: 2.0.0-plugins
> Environment: Windows XP / JSF 2.0
> Reporter: Pavitra Subramaniam
> Assignee: Matthias Weßendorf
> Fix For: 2.0.0-plugins
>
> Attachments: Issue1659.patch
>
>
> 1. When tryjng to register a new factory - PartialViewContextFactory - in faces-config-base.xml in trinidad-impl, I noticed that the generated faces-config.xml did not have the factory element I added. It should look like this (see last element)
> <factory>
> <faces-context-factory>org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl</faces-context-factory>
> <render-kit-factory>org.apache.myfaces.trinidadinternal.renderkit.CoreRenderKitFactory</render-kit-factory>
> <partial-view-context-factory>org.apache.myfaces.trinidadinternal.context.PartialViewContextFactoryImpl</partial-view-context-factory>
> </factory>
> 2. Turns out the transform20.xsl used to parse and generate the faces-config was not looking for this new element. Code changes were required in transform20.xsl (maven-faces-plugin\src\main\resources\org\apache\myfaces\trinidadbuild\plugin\faces\resources)
> 3. Making the necessary updates in the file, compiling and using the plugin JARS to build trinidad, worked. AS in the generated faces-config.xml did contain the entry I added for the <partial-view-context-factory>
> 4. See attached patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.