You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/08 09:19:37 UTC
[GitHub] [skywalking] sialais opened a new issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
sialais opened a new issue #7875:
URL: https://github.com/apache/skywalking/issues/7875
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
Java Agent (apache/skywalking-java)
### What happened
we config trace ignore paths by "agent/config/pm-trace-ignore-plugin.config", but found paths ends by "/" are not ignored with "**".
example configuration in pm-trace-ignore-plugin.config:
```text
trace.ignore_path=/v1/kv/config/**
```
request path "/v1/kv/config/someurl/" is not ignored.
### What you expected to happen
request path "/v1/kv/config/someurl/" (end with slash) should be ignored, as ""/v1/kv/config/someurl"(not end with slash)
### How to reproduce
just run agent with example config.
### Anything else
Ant path match style should match paths end with slash. [Spring AntPathMatcher](https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/AntPathMatcher.html).
In skywalking-java-agent, there are unit tests for this, but they do not act in the way "ant path matcher" describes.
- https://github.com/apache/skywalking-java/blob/v8.7.0/apm-sniffer/optional-plugins/trace-ignore-plugin/src/test/java/org/apache/skywalking/apm/plugin/trace/ignore/TracePathMatcherTest.java#L62
- https://github.com/apache/skywalking-java/blob/v8.7.0/apm-sniffer/optional-plugins/trace-ignore-plugin/src/test/java/org/apache/skywalking/apm/plugin/trace/ignore/TracePathMatcherTest.java#L97
they should return true, as described in [skywalking doc](https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/agent-optional-plugins/trace-ignore-plugin/#how-to-configure)
> The current matching rules follow Ant Path match style , like /path/*, /path/**, /path/?.
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7875:
URL: https://github.com/apache/skywalking/issues/7875#issuecomment-990404900
Review will take time. You submitted at my night. 😄
I have pinged the plugin author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7875:
URL: https://github.com/apache/skywalking/issues/7875#issuecomment-968514765
Assigbed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7875:
URL: https://github.com/apache/skywalking/issues/7875#issuecomment-938525218
Welcome to submit a pull request to fix and add a new UT to cover new case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] DominikHubacek commented on issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
DominikHubacek commented on issue #7875:
URL: https://github.com/apache/skywalking/issues/7875#issuecomment-986691723
> > Hi, I d like to fix this issue, please assign it to me.
>
> Done, please refer to precious PR, there are some edge case discussions there.
Which PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7875:
URL: https://github.com/apache/skywalking/issues/7875#issuecomment-986694663
> https://github.com/apache/skywalking-java/pull/72 gets no update.
This one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] newboy2004 commented on issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
newboy2004 commented on issue #7875:
URL: https://github.com/apache/skywalking/issues/7875#issuecomment-968513863
i want to submit a pull request to fix it and add a new UT
please assign it to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] DominikHubacek commented on issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
DominikHubacek commented on issue #7875:
URL: https://github.com/apache/skywalking/issues/7875#issuecomment-990162398
@wu-sheng I created PR - but I am unable to set you for review
PR: https://github.com/apache/skywalking-java/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] DominikHubacek commented on issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
DominikHubacek commented on issue #7875:
URL: https://github.com/apache/skywalking/issues/7875#issuecomment-986660668
Hi, I d like to fix this issue, please assign it to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7875:
URL: https://github.com/apache/skywalking/issues/7875#issuecomment-986661678
> Hi, I d like to fix this issue, please assign it to me.
Done, please refer to precious PR, there are some edge case discussions there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7875:
URL: https://github.com/apache/skywalking/issues/7875#issuecomment-986603581
https://github.com/apache/skywalking-java/pull/72 gets no update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7875: [Bug] TracePathMatcher should match pattern "**" with paths end by "/"
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7875:
URL: https://github.com/apache/skywalking/issues/7875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org