You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/21 14:52:30 UTC

[GitHub] [ozone] dombizita opened a new pull request, #3770: HDDS-7240. List all volume operation should go through ACL check as well in order to trigger audit logging

dombizita opened a new pull request, #3770:
URL: https://github.com/apache/ozone/pull/3770

   ## What changes were proposed in this pull request?
   
   Previously the list all volume operation only went through the ACL check if the list all volume was disabled. Because of this the audit logging wasn't triggered. I removed the if condition checking the `ozone.om.volume.listall.allowed`'s value, so the ACL check gets triggered in every case (if the ACL is enabled). I also updated the `ozone.om.volume.listall.allowed`'s description in `ozone-default.xml`.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-7240
   
   ## How was this patch tested?
   
   Run related tests. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] smengcl merged pull request #3770: HDDS-7240. List all volume operation should go through ACL check as well in order to trigger audit logging

Posted by GitBox <gi...@apache.org>.
smengcl merged PR #3770:
URL: https://github.com/apache/ozone/pull/3770


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] kerneltime commented on pull request #3770: HDDS-7240. List all volume operation should go through ACL check as well in order to trigger audit logging

Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3770:
URL: https://github.com/apache/ozone/pull/3770#issuecomment-1254222656

   cc @duongkame 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] smengcl commented on pull request #3770: HDDS-7240. List all volume operation should go through ACL check as well in order to trigger audit logging

Posted by GitBox <gi...@apache.org>.
smengcl commented on PR #3770:
URL: https://github.com/apache/ozone/pull/3770#issuecomment-1255514528

   Thanks @dombizita for the patch. Thanks @duongkame for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org