[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

["szaszm (via GitHub)" <gi...@apache.org>]

szaszm commented on code in PR #1498:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1088076713


##########
minifi_main/MiNiFiWindowsService.h:
##########
@@ -20,10 +20,12 @@
 #ifdef WIN32
 
 #include <memory>
+#include <utility>
+
 #include "core/Core.h"
 
 void RunAsServiceIfNeeded();
-HANDLE GetTerminationEventHandle(bool* isStartedByService);
+std::tuple<bool, HANDLE> GetTerminationEventHandle();

Review Comment:
   I think a trivial aggregate struct would be better, since it would allow naming the parts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org