You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/25 17:39:02 UTC
[GitHub] [hbase] virajjasani opened a new pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
virajjasani opened a new pull request #2312:
URL: https://github.com/apache/hbase/pull/2312
-----------------
**WIP**
-----------------
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-698407220
> The checkstyle results from precommit should be cleaned up.
checkstyle issue present in the precommit is not relevant to the source code we are updating as part of this patch.
> The rubocop results from precommit look like they apply in many cases
Sure, applying majority of them.
> Please clean up the commit message. How about...
Sure, it makes it easier to identify changes clubbed.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-689190018
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 12m 24s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 9s | branch-1 passed |
| +1 :green_heart: | compile | 1m 48s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 55s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 34s | branch-1 passed |
| +0 :ok: | refguide | 4m 9s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 15s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 35s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 2s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 19m 13s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 3s | the patch passed |
| +1 :green_heart: | compile | 1m 48s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 48s | the patch passed |
| +1 :green_heart: | javac | 1m 48s | the patch passed |
| +1 :green_heart: | compile | 1m 57s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 57s | the patch passed |
| -1 :x: | javac | 1m 57s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 0m 47s | hbase-client: The patch generated 1 new + 628 unchanged - 0 fixed = 629 total (was 628) |
| -1 :x: | checkstyle | 1m 52s | hbase-server: The patch generated 6 new + 524 unchanged - 0 fixed = 530 total (was 524) |
| -1 :x: | checkstyle | 6m 16s | root: The patch generated 7 new + 1161 unchanged - 0 fixed = 1168 total (was 1161) |
| -1 :x: | rubocop | 0m 15s | The patch generated 19 new + 829 unchanged - 1 fixed = 848 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 12s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 6s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 51s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 32s | the patch passed |
| +1 :green_heart: | javadoc | 3m 39s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 55s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 20m 32s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 175m 47s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 10s | The patch does not generate ASF License warnings. |
| | | 323m 25s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.procedure.TestFailedProcCleanup |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 9f57ff7825cf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / e5c0a94 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/testReport/ |
| Max. process+thread count | 4921 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-693586177
Javadoc issue in the latest build is also not relevant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on a change in pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#discussion_r506057237
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1401,6 +1401,22 @@
*/
public static final int BATCH_ROWS_THRESHOLD_DEFAULT = 5000;
+ public static final int DEFAULT_SLOW_LOG_RING_BUFFER_SIZE = 256;
Review comment:
why do we still introduce these parameters in HConstants. I thought we have avoided to add parameters in it for quite a long time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-693585181
checkstyle issues belong to part of the code that is not updated in this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#discussion_r506085083
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
##########
@@ -0,0 +1,154 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.slowlog;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.protobuf.generated.TooSlowLog;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Slowlog Accessor to record slow/large RPC log identified at each RegionServer RpcServer level.
+ * This can be done only optionally to record the entire history of slow/large rpc calls
+ * since RingBuffer can handle only limited latest records.
+ */
+@InterfaceAudience.Private
+public final class SlowLogTableAccessor {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SlowLogTableAccessor.class);
+
+ private static final Random RANDOM = new Random();
+
+ private static Connection connection;
+
+ private SlowLogTableAccessor() {
+ }
+
+ /**
+ * hbase:slowlog table name - can be enabled
+ * with config - hbase.regionserver.slowlog.systable.enabled
+ */
+ public static final TableName SLOW_LOG_TABLE_NAME =
+ TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "slowlog");
+
+ private static void doPut(final Connection connection, final List<Put> puts)
+ throws IOException {
+ try (Table table = connection.getTable(SLOW_LOG_TABLE_NAME)) {
Review comment:
@Reidddddd if you are fine, let me take care of this separately i.e search for similar utility or handle it separately here. Otherwise I hope for backport this might not be a concern.
Btw we are doing this (which should be executed once):
```
try {
if (connection == null) {
createConnection(configuration);
}
doPut(connection, puts);
} catch (Exception e) {
LOG.warn("Failed to add slow/large log records to hbase:slowlog table.", e);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-708882093
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 11m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 7s | branch-1 passed |
| +1 :green_heart: | compile | 1m 45s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 58s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 34s | branch-1 passed |
| +0 :ok: | refguide | 4m 10s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 15s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 33s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 2s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 55s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 19m 15s | branch-1 passed |
| -0 :warning: | patch | 3m 36s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 8s | the patch passed |
| +1 :green_heart: | compile | 1m 48s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 48s | the patch passed |
| +1 :green_heart: | javac | 1m 48s | the patch passed |
| +1 :green_heart: | compile | 1m 57s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 57s | the patch passed |
| -1 :x: | javac | 1m 57s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| +1 :green_heart: | checkstyle | 13m 1s | the patch passed |
| -1 :x: | rubocop | 0m 18s | The patch generated 15 new + 829 unchanged - 1 fixed = 844 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 12s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 8s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 56s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 32s | the patch passed |
| +1 :green_heart: | javadoc | 3m 34s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 5s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 20m 48s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 173m 14s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 1s | The patch does not generate ASF License warnings. |
| | | 321m 0s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/24/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux d3f14729a0f4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / e4a8dcc |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/24/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/24/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/24/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/24/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/24/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/24/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/24/testReport/ |
| Max. process+thread count | 3405 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/24/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-686776007
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 12m 12s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 7s | root in branch-1 failed. |
| +1 :green_heart: | compile | 8m 52s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 59s | branch-1 passed with JDK v1.7.0_272 |
| -1 :x: | checkstyle | 0m 20s | The patch fails to run checkstyle in root |
| -1 :x: | checkstyle | 0m 13s | The patch fails to run checkstyle in hbase-client |
| -1 :x: | checkstyle | 0m 7s | The patch fails to run checkstyle in hbase-common |
| -1 :x: | checkstyle | 0m 7s | The patch fails to run checkstyle in hbase-protocol |
| -1 :x: | checkstyle | 0m 24s | The patch fails to run checkstyle in hbase-server |
| -1 :x: | checkstyle | 0m 17s | The patch fails to run checkstyle in hbase-shell |
| +0 :ok: | refguide | 5m 3s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 32s | branch has no errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 20s | root in branch-1 failed with JDK v1.8.0_262. |
| -1 :x: | javadoc | 0m 8s | hbase-client in branch-1 failed with JDK v1.8.0_262. |
| -1 :x: | javadoc | 0m 8s | hbase-common in branch-1 failed with JDK v1.8.0_262. |
| -1 :x: | javadoc | 0m 8s | hbase-protocol in branch-1 failed with JDK v1.8.0_262. |
| -1 :x: | javadoc | 0m 9s | hbase-server in branch-1 failed with JDK v1.8.0_262. |
| -1 :x: | javadoc | 0m 8s | hbase-shell in branch-1 failed with JDK v1.8.0_262. |
| -1 :x: | javadoc | 0m 14s | root in branch-1 failed with JDK v1.7.0_272. |
| -1 :x: | javadoc | 0m 10s | hbase-client in branch-1 failed with JDK v1.7.0_272. |
| -1 :x: | javadoc | 0m 10s | hbase-common in branch-1 failed with JDK v1.7.0_272. |
| -1 :x: | javadoc | 0m 9s | hbase-protocol in branch-1 failed with JDK v1.7.0_272. |
| -1 :x: | javadoc | 0m 11s | hbase-server in branch-1 failed with JDK v1.7.0_272. |
| -1 :x: | javadoc | 0m 11s | hbase-shell in branch-1 failed with JDK v1.7.0_272. |
| +0 :ok: | spotbugs | 12m 12s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| -1 :x: | findbugs | 0m 11s | hbase-client in branch-1 failed. |
| -1 :x: | findbugs | 0m 10s | hbase-common in branch-1 failed. |
| -1 :x: | findbugs | 0m 8s | hbase-protocol in branch-1 failed. |
| -1 :x: | findbugs | 0m 13s | hbase-server in branch-1 failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 26s | the patch passed |
| +1 :green_heart: | compile | 1m 51s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 51s | the patch passed |
| +1 :green_heart: | javac | 1m 51s | the patch passed |
| +1 :green_heart: | compile | 1m 59s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 59s | the patch passed |
| -1 :x: | javac | 1m 59s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 6m 8s | root: The patch generated 1168 new + 0 unchanged - 0 fixed = 1168 total (was 0) |
| -1 :x: | checkstyle | 0m 46s | hbase-client: The patch generated 629 new + 0 unchanged - 0 fixed = 629 total (was 0) |
| -1 :x: | checkstyle | 0m 29s | hbase-common: The patch generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0) |
| -1 :x: | checkstyle | 1m 49s | hbase-server: The patch generated 530 new + 0 unchanged - 0 fixed = 530 total (was 0) |
| -1 :x: | rubocop | 0m 16s | The patch generated 19 new + 829 unchanged - 1 fixed = 848 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 17s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 9s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 7s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 25s | the patch passed |
| -1 :x: | javadoc | 2m 9s | root-jdk1.8.0_262 with JDK v1.8.0_262 generated 11 new + 0 unchanged - 0 fixed = 11 total (was 0) |
| -1 :x: | javadoc | 0m 18s | hbase-client-jdk1.8.0_262 with JDK v1.8.0_262 generated 14 new + 0 unchanged - 0 fixed = 14 total (was 0) |
| -1 :x: | javadoc | 0m 17s | hbase-common-jdk1.8.0_262 with JDK v1.8.0_262 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -1 :x: | javadoc | 0m 30s | hbase-server-jdk1.8.0_262 with JDK v1.8.0_262 generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0) |
| -1 :x: | javadoc | 4m 15s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0) |
| -1 :x: | javadoc | 0m 25s | hbase-client-jdk1.7.0_272 with JDK v1.7.0_272 generated 14 new + 0 unchanged - 0 fixed = 14 total (was 0) |
| -1 :x: | javadoc | 0m 22s | hbase-common-jdk1.7.0_272 with JDK v1.7.0_272 generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) |
| -1 :x: | javadoc | 0m 42s | hbase-server-jdk1.7.0_272 with JDK v1.7.0_272 generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0) |
| +1 :green_heart: | findbugs | 20m 19s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 171m 57s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 14s | The patch does not generate ASF License warnings. |
| | | 292m 43s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
| | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 8185945bd6d4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / 76db1e1 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-mvninstall-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out//home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/maven-branch-checkstyle-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out//home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/maven-branch-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out//home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/maven-branch-checkstyle-hbase-common.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out//home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/maven-branch-checkstyle-hbase-protocol.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out//home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/maven-branch-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out//home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/maven-branch-checkstyle-hbase-shell.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-site/book.html |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-root-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-hbase-client-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-hbase-common-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-hbase-protocol-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-hbase-server-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-hbase-shell-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-root-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-hbase-client-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-hbase-common-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-hbase-protocol-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-hbase-server-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-javadoc-hbase-shell-jdk1.7.0_272.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-findbugs-hbase-client.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-findbugs-hbase-common.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-findbugs-hbase-protocol.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/branch-findbugs-hbase-server.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-checkstyle-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-checkstyle-hbase-common.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-checkstyle-hbase-server.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/patch-site/book.html |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-javadoc-javadoc-root-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-javadoc-javadoc-hbase-common-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-javadoc-javadoc-hbase-server-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-javadoc-javadoc-root-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-javadoc-javadoc-hbase-common-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/diff-javadoc-javadoc-hbase-server-jdk1.7.0_272.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/testReport/ |
| Max. process+thread count | 4364 (vs. ulimit of 10000) |
| modules | C: . hbase-client hbase-common hbase-protocol hbase-server hbase-shell U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/6/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani merged pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani merged pull request #2312:
URL: https://github.com/apache/hbase/pull/2312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-698611839
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 52s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 23s | branch-1 passed |
| +1 :green_heart: | compile | 1m 45s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 55s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 38s | branch-1 passed |
| +0 :ok: | refguide | 4m 13s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 16s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 31s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 2s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 16s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 20m 43s | branch-1 passed |
| -0 :warning: | patch | 4m 4s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 24s | the patch passed |
| +1 :green_heart: | compile | 2m 3s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 2m 3s | the patch passed |
| +1 :green_heart: | javac | 2m 3s | the patch passed |
| +1 :green_heart: | compile | 2m 14s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 2m 14s | the patch passed |
| -1 :x: | javac | 2m 14s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| +1 :green_heart: | checkstyle | 14m 59s | the patch passed |
| -1 :x: | rubocop | 0m 20s | The patch generated 15 new + 829 unchanged - 1 fixed = 844 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 4m 19s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 4m 47s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 7m 37s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 7m 26s | the patch passed |
| +1 :green_heart: | javadoc | 4m 23s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 7m 48s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 25m 18s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 189m 12s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 8s | The patch does not generate ASF License warnings. |
| | | 352m 57s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 0b17ef4be6d4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / f52d64c |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/testReport/ |
| Max. process+thread count | 3640 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-695087742
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 8s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 6s | branch-1 passed |
| +1 :green_heart: | compile | 1m 47s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 59s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 36s | branch-1 passed |
| +0 :ok: | refguide | 4m 10s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 18s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 36s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 3s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 19m 6s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 6s | the patch passed |
| +1 :green_heart: | compile | 1m 45s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 45s | the patch passed |
| +1 :green_heart: | javac | 1m 45s | the patch passed |
| +1 :green_heart: | compile | 1m 59s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 59s | the patch passed |
| -1 :x: | javac | 1m 59s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 1m 56s | hbase-server: The patch generated 2 new + 655 unchanged - 0 fixed = 657 total (was 655) |
| -1 :x: | checkstyle | 6m 13s | root: The patch generated 5 new + 1355 unchanged - 3 fixed = 1360 total (was 1358) |
| -1 :x: | rubocop | 0m 17s | The patch generated 25 new + 829 unchanged - 1 fixed = 854 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 18s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 8s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 57s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 29s | the patch passed |
| -1 :x: | javadoc | 0m 18s | hbase-client-jdk1.8.0_262 with JDK v1.8.0_262 generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) |
| -1 :x: | javadoc | 2m 9s | root-jdk1.8.0_262 with JDK v1.8.0_262 generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11) |
| -1 :x: | javadoc | 0m 28s | hbase-client-jdk1.7.0_272 with JDK v1.7.0_272 generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) |
| -1 :x: | javadoc | 4m 25s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) |
| +1 :green_heart: | findbugs | 20m 49s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 10m 19s | root in the patch failed. |
| +1 :green_heart: | asflicense | 1m 14s | The patch does not generate ASF License warnings. |
| | | 146m 20s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 624a8e4987f6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / f0acafc |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/patch-site/book.html |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/diff-javadoc-javadoc-root-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/diff-javadoc-javadoc-root-jdk1.7.0_272.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/testReport/ |
| Max. process+thread count | 171 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/19/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-689928945
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 14m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 42s | branch-1 passed |
| +1 :green_heart: | compile | 2m 17s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 2m 21s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 14m 51s | branch-1 passed |
| +0 :ok: | refguide | 5m 22s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 47s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 22s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 7m 8s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 30s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 23m 2s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 43s | the patch passed |
| +1 :green_heart: | compile | 2m 11s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 2m 11s | the patch passed |
| +1 :green_heart: | javac | 2m 11s | the patch passed |
| +1 :green_heart: | compile | 2m 13s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 2m 13s | the patch passed |
| -1 :x: | javac | 2m 13s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 0m 54s | hbase-client: The patch generated 8 new + 625 unchanged - 3 fixed = 633 total (was 628) |
| -1 :x: | checkstyle | 7m 22s | root: The patch generated 8 new + 1158 unchanged - 3 fixed = 1166 total (was 1161) |
| -1 :x: | rubocop | 0m 22s | The patch generated 19 new + 829 unchanged - 1 fixed = 848 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 50s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 38s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 48s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 5m 9s | the patch passed |
| -1 :x: | javadoc | 0m 24s | hbase-client-jdk1.8.0_262 with JDK v1.8.0_262 generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) |
| -1 :x: | javadoc | 2m 42s | root-jdk1.8.0_262 with JDK v1.8.0_262 generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11) |
| -1 :x: | javadoc | 0m 27s | hbase-client-jdk1.7.0_272 with JDK v1.7.0_272 generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) |
| -1 :x: | javadoc | 5m 23s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) |
| +1 :green_heart: | findbugs | 24m 32s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 205m 59s | root in the patch failed. |
| +1 :green_heart: | asflicense | 3m 25s | The patch does not generate ASF License warnings. |
| | | 382m 0s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
| | hadoop.hbase.master.TestMasterBalanceThrottling |
| | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 450c7c81ff89 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / e5c0a94 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/patch-site/book.html |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/diff-javadoc-javadoc-root-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/diff-javadoc-javadoc-root-jdk1.7.0_272.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/testReport/ |
| Max. process+thread count | 4201 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/12/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-695781306
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 5s | branch-1 passed |
| +1 :green_heart: | compile | 1m 50s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 54s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 54s | branch-1 passed |
| +0 :ok: | refguide | 4m 11s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 17s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 46s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 3s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 2s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 19m 41s | branch-1 passed |
| -0 :warning: | patch | 3m 43s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 27s | the patch passed |
| +1 :green_heart: | compile | 1m 57s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 57s | the patch passed |
| +1 :green_heart: | javac | 1m 57s | the patch passed |
| +1 :green_heart: | compile | 1m 59s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 59s | the patch passed |
| -1 :x: | javac | 1m 59s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 0m 49s | hbase-client: The patch generated 3 new + 690 unchanged - 3 fixed = 693 total (was 693) |
| -1 :x: | checkstyle | 6m 26s | root: The patch generated 3 new + 1355 unchanged - 3 fixed = 1358 total (was 1358) |
| -1 :x: | rubocop | 0m 19s | The patch generated 25 new + 829 unchanged - 1 fixed = 854 total (was 830) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 41s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 32s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 19s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 32s | the patch passed |
| +1 :green_heart: | javadoc | 3m 35s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 59s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 20m 47s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 10m 22s | root in the patch failed. |
| +1 :green_heart: | asflicense | 1m 14s | The patch does not generate ASF License warnings. |
| | | 150m 15s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 27c8ca1472b1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / 55cae10 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/testReport/ |
| Max. process+thread count | 171 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/21/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#discussion_r506083771
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -430,7 +440,7 @@ protected boolean needsBalance(Cluster cluster) {
System.arraycopy(tempFunctionCosts, 0, curFunctionCosts, 0, this.curFunctionCosts.length);
double initCost = currentCost;
- double newCost = currentCost;
+ double newCost;
Review comment:
Oh this is anyways a redundant assignment, not an issue. It's not being used anywhere other than for loop and inside that loop, it is always assigned with new value. In fact, this was removed from trunk and branch-2 as well. I am confident this is not problematic at all.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
##########
@@ -0,0 +1,154 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.slowlog;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.protobuf.generated.TooSlowLog;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Slowlog Accessor to record slow/large RPC log identified at each RegionServer RpcServer level.
+ * This can be done only optionally to record the entire history of slow/large rpc calls
+ * since RingBuffer can handle only limited latest records.
+ */
+@InterfaceAudience.Private
+public final class SlowLogTableAccessor {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SlowLogTableAccessor.class);
+
+ private static final Random RANDOM = new Random();
+
+ private static Connection connection;
+
+ private SlowLogTableAccessor() {
+ }
+
+ /**
+ * hbase:slowlog table name - can be enabled
+ * with config - hbase.regionserver.slowlog.systable.enabled
+ */
+ public static final TableName SLOW_LOG_TABLE_NAME =
+ TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "slowlog");
+
+ private static void doPut(final Connection connection, final List<Put> puts)
+ throws IOException {
+ try (Table table = connection.getTable(SLOW_LOG_TABLE_NAME)) {
Review comment:
That's nice idea. Do we already do this as part of some utility? Then I can utilize it here?
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1401,6 +1401,22 @@
*/
public static final int BATCH_ROWS_THRESHOLD_DEFAULT = 5000;
+ public static final int DEFAULT_SLOW_LOG_RING_BUFFER_SIZE = 256;
Review comment:
That's right, we don't do this anymore. I think the initial patch had multiple references in various classes and hence, we kept all here. e.g `SLOW_LOG_BUFFER_ENABLED_KEY` is being referred to at 4 places and similarly others too, but since this is a group of constant (usually something that should stay together), they are kept here.
Sounds good?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
##########
@@ -0,0 +1,154 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.slowlog;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.protobuf.generated.TooSlowLog;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Slowlog Accessor to record slow/large RPC log identified at each RegionServer RpcServer level.
+ * This can be done only optionally to record the entire history of slow/large rpc calls
+ * since RingBuffer can handle only limited latest records.
+ */
+@InterfaceAudience.Private
+public final class SlowLogTableAccessor {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SlowLogTableAccessor.class);
+
+ private static final Random RANDOM = new Random();
+
+ private static Connection connection;
+
+ private SlowLogTableAccessor() {
+ }
+
+ /**
+ * hbase:slowlog table name - can be enabled
+ * with config - hbase.regionserver.slowlog.systable.enabled
+ */
+ public static final TableName SLOW_LOG_TABLE_NAME =
+ TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "slowlog");
+
+ private static void doPut(final Connection connection, final List<Put> puts)
+ throws IOException {
+ try (Table table = connection.getTable(SLOW_LOG_TABLE_NAME)) {
+ table.put(puts);
+ }
+ }
+
+ /**
+ * Add slow/large log records to hbase:slowlog table
+ * @param slowLogPayloads List of SlowLogPayload to process
+ * @param configuration Configuration to use for connection
+ */
+ public static void addSlowLogRecords(final List<TooSlowLog.SlowLogPayload> slowLogPayloads,
+ final Configuration configuration) {
+ List<Put> puts = new ArrayList<>(slowLogPayloads.size());
+ for (TooSlowLog.SlowLogPayload slowLogPayload : slowLogPayloads) {
+ final byte[] rowKey = getRowKey(slowLogPayload);
+ final Put put = new Put(rowKey);
+ put.setDurability(Durability.SKIP_WAL);
+ put.setPriority(HConstants.NORMAL_QOS);
+ put.addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("call_details"),
+ Bytes.toBytes(slowLogPayload.getCallDetails()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("client_address"),
+ Bytes.toBytes(slowLogPayload.getClientAddress()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("method_name"),
+ Bytes.toBytes(slowLogPayload.getMethodName()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("param"),
+ Bytes.toBytes(slowLogPayload.getParam()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("processing_time"),
+ Bytes.toBytes(Integer.toString(slowLogPayload.getProcessingTime())))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("queue_time"),
+ Bytes.toBytes(Integer.toString(slowLogPayload.getQueueTime())))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("region_name"),
+ Bytes.toBytes(slowLogPayload.getRegionName()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("response_size"),
+ Bytes.toBytes(Long.toString(slowLogPayload.getResponseSize())))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("server_class"),
+ Bytes.toBytes(slowLogPayload.getServerClass()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("start_time"),
+ Bytes.toBytes(Long.toString(slowLogPayload.getStartTime())))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("type"),
+ Bytes.toBytes(slowLogPayload.getType().name()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("username"),
+ Bytes.toBytes(slowLogPayload.getUserName()));
+ puts.add(put);
Review comment:
Here, the intention is to just collect list of puts and then carry it over to `doPut()` method on L116.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-698407220
> The checkstyle results from precommit should be cleaned up.
checkstyle issue present in the precommit is not relevant to the source code we are updating as part of this patch.
> The rubocop results from precommit look like they apply in many cases
Sure, applying majority of them.
> Please clean up the commit message. How about...
Sure, it makes it easier to identify changes clubbed.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-698611839
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 52s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 23s | branch-1 passed |
| +1 :green_heart: | compile | 1m 45s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 55s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 38s | branch-1 passed |
| +0 :ok: | refguide | 4m 13s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 16s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 31s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 2s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 16s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 20m 43s | branch-1 passed |
| -0 :warning: | patch | 4m 4s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 24s | the patch passed |
| +1 :green_heart: | compile | 2m 3s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 2m 3s | the patch passed |
| +1 :green_heart: | javac | 2m 3s | the patch passed |
| +1 :green_heart: | compile | 2m 14s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 2m 14s | the patch passed |
| -1 :x: | javac | 2m 14s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| +1 :green_heart: | checkstyle | 14m 59s | the patch passed |
| -1 :x: | rubocop | 0m 20s | The patch generated 15 new + 829 unchanged - 1 fixed = 844 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 4m 19s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 4m 47s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 7m 37s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 7m 26s | the patch passed |
| +1 :green_heart: | javadoc | 4m 23s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 7m 48s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 25m 18s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 189m 12s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 8s | The patch does not generate ASF License warnings. |
| | | 352m 57s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 0b17ef4be6d4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / f52d64c |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/testReport/ |
| Max. process+thread count | 3640 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/23/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#discussion_r506085083
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
##########
@@ -0,0 +1,154 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.slowlog;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.protobuf.generated.TooSlowLog;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Slowlog Accessor to record slow/large RPC log identified at each RegionServer RpcServer level.
+ * This can be done only optionally to record the entire history of slow/large rpc calls
+ * since RingBuffer can handle only limited latest records.
+ */
+@InterfaceAudience.Private
+public final class SlowLogTableAccessor {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SlowLogTableAccessor.class);
+
+ private static final Random RANDOM = new Random();
+
+ private static Connection connection;
+
+ private SlowLogTableAccessor() {
+ }
+
+ /**
+ * hbase:slowlog table name - can be enabled
+ * with config - hbase.regionserver.slowlog.systable.enabled
+ */
+ public static final TableName SLOW_LOG_TABLE_NAME =
+ TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "slowlog");
+
+ private static void doPut(final Connection connection, final List<Put> puts)
+ throws IOException {
+ try (Table table = connection.getTable(SLOW_LOG_TABLE_NAME)) {
Review comment:
@Reidddddd if you are fine, let me take care of this separately i.e search for similar utility or handle it separately here. Otherwise I hope for backport this might not be a concern.
Btw we are doing this (creating connection should be executed once):
```
try {
if (connection == null) {
createConnection(configuration);
}
doPut(connection, puts);
} catch (Exception e) {
LOG.warn("Failed to add slow/large log records to hbase:slowlog table.", e);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on a change in pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#discussion_r506056833
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
##########
@@ -0,0 +1,154 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.slowlog;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.protobuf.generated.TooSlowLog;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Slowlog Accessor to record slow/large RPC log identified at each RegionServer RpcServer level.
+ * This can be done only optionally to record the entire history of slow/large rpc calls
+ * since RingBuffer can handle only limited latest records.
+ */
+@InterfaceAudience.Private
+public final class SlowLogTableAccessor {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SlowLogTableAccessor.class);
+
+ private static final Random RANDOM = new Random();
+
+ private static Connection connection;
+
+ private SlowLogTableAccessor() {
+ }
+
+ /**
+ * hbase:slowlog table name - can be enabled
+ * with config - hbase.regionserver.slowlog.systable.enabled
+ */
+ public static final TableName SLOW_LOG_TABLE_NAME =
+ TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "slowlog");
+
+ private static void doPut(final Connection connection, final List<Put> puts)
+ throws IOException {
+ try (Table table = connection.getTable(SLOW_LOG_TABLE_NAME)) {
Review comment:
This can be done afterwards.
There's one case, when a server gets stuck, every call is a slow response. Then your connection will be created-closed, created-closed many times.
So here I suggest, we should create something like TTL, if the connections hasn't been touched for a time, there then we close it, otherwise we should keep it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-693726658
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 11m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 35s | branch-1 passed |
| +1 :green_heart: | compile | 1m 48s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 56s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 37s | branch-1 passed |
| +0 :ok: | refguide | 4m 13s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 17s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 37s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 2s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 57s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 19m 22s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 5s | the patch passed |
| +1 :green_heart: | compile | 1m 47s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 47s | the patch passed |
| +1 :green_heart: | javac | 1m 47s | the patch passed |
| +1 :green_heart: | compile | 1m 56s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 56s | the patch passed |
| -1 :x: | javac | 1m 56s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 0m 48s | hbase-client: The patch generated 3 new + 625 unchanged - 3 fixed = 628 total (was 628) |
| -1 :x: | checkstyle | 6m 7s | root: The patch generated 3 new + 1158 unchanged - 3 fixed = 1161 total (was 1161) |
| -1 :x: | rubocop | 0m 16s | The patch generated 19 new + 829 unchanged - 1 fixed = 848 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 16s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 7s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 55s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 34s | the patch passed |
| +1 :green_heart: | javadoc | 3m 43s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 1s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 20m 41s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 174m 15s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 16s | The patch does not generate ASF License warnings. |
| | | 321m 49s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.client.TestAdmin1 |
| | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 1de69ed3c778 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / 7801b45 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/testReport/ |
| Max. process+thread count | 4940 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/16/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-695781306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-680994901
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 13m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 13s | branch-1 passed |
| +1 :green_heart: | compile | 1m 49s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 2m 5s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 13m 5s | branch-1 passed |
| +0 :ok: | refguide | 4m 26s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 24s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 58s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 8s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 0s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 19m 55s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 19s | the patch passed |
| +1 :green_heart: | compile | 2m 26s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 2m 26s | the patch passed |
| +1 :green_heart: | javac | 2m 26s | the patch passed |
| +1 :green_heart: | compile | 2m 22s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 2m 22s | the patch passed |
| -1 :x: | javac | 2m 22s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 0m 55s | hbase-client: The patch generated 3 new + 628 unchanged - 0 fixed = 631 total (was 628) |
| -1 :x: | checkstyle | 1m 59s | hbase-server: The patch generated 9 new + 524 unchanged - 0 fixed = 533 total (was 524) |
| -1 :x: | checkstyle | 6m 46s | root: The patch generated 12 new + 1161 unchanged - 0 fixed = 1173 total (was 1161) |
| -1 :x: | rubocop | 0m 17s | The patch generated 19 new + 826 unchanged - 1 fixed = 845 total (was 827) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 38s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 4m 4s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 57s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 6m 4s | the patch passed |
| +1 :green_heart: | javadoc | 4m 51s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 7m 32s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 24m 2s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 213m 56s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 53s | The patch does not generate ASF License warnings. |
| | | 379m 14s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux b1aa8e40f913 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / 8f946be |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/testReport/ |
| Max. process+thread count | 5148 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/3/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-698407220
> The checkstyle results from precommit should be cleaned up.
checkstyle issue present in the precommit is not relevant to the source code we are updating as part of this patch.
> The rubocop results from precommit look like they apply in many cases
Sure, applying majority of them.
> Please clean up the commit message. How about...
Sure, it makes it easier to identify changes clubbed.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-689503922
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 11m 25s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 13s | branch-1 passed |
| +1 :green_heart: | compile | 1m 47s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 56s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 20s | branch-1 passed |
| +0 :ok: | refguide | 4m 6s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 17s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 32s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 1s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 55s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 19m 15s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 7s | the patch passed |
| +1 :green_heart: | compile | 1m 45s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 45s | the patch passed |
| +1 :green_heart: | javac | 1m 45s | the patch passed |
| +1 :green_heart: | compile | 1m 57s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 57s | the patch passed |
| -1 :x: | javac | 1m 57s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 0m 47s | hbase-client: The patch generated 3 new + 625 unchanged - 3 fixed = 628 total (was 628) |
| -1 :x: | checkstyle | 6m 7s | root: The patch generated 3 new + 1158 unchanged - 3 fixed = 1161 total (was 1161) |
| -1 :x: | rubocop | 0m 16s | The patch generated 19 new + 829 unchanged - 1 fixed = 848 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 18s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 8s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 0s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 36s | the patch passed |
| +1 :green_heart: | javadoc | 3m 39s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 0s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 20m 57s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 178m 39s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 17s | The patch does not generate ASF License warnings. |
| | | 326m 4s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.TestPartialResultsFromClientSide |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 975856f347c6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / e5c0a94 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/testReport/ |
| Max. process+thread count | 4780 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/10/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-695820221
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 26s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 59s | branch-1 passed |
| +1 :green_heart: | compile | 1m 46s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 55s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 45s | branch-1 passed |
| +0 :ok: | refguide | 4m 11s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 14s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 34s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 0s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 56s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 19m 20s | branch-1 passed |
| -0 :warning: | patch | 3m 38s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 4s | the patch passed |
| +1 :green_heart: | compile | 1m 49s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 49s | the patch passed |
| +1 :green_heart: | javac | 1m 49s | the patch passed |
| +1 :green_heart: | compile | 1m 53s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 53s | the patch passed |
| -1 :x: | javac | 1m 53s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 0m 49s | hbase-client: The patch generated 3 new + 690 unchanged - 3 fixed = 693 total (was 693) |
| -1 :x: | rubocop | 0m 18s | The patch generated 25 new + 829 unchanged - 1 fixed = 854 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 13s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 6s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 52s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 32s | the patch passed |
| +1 :green_heart: | javadoc | 3m 38s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 2s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 20m 46s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 182m 11s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 11s | The patch does not generate ASF License warnings. |
| | | 319m 46s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/22/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux d21fa4295d26 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / 55cae10 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/22/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/22/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/22/artifact/out/diff-checkstyle-hbase-client.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/22/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/22/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/22/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/22/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/22/testReport/ |
| Max. process+thread count | 4697 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/22/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-698409800
Updated PR subject (commit message) and PR description (commit description).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-694991813
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 11m 22s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 5s | branch-1 passed |
| +1 :green_heart: | compile | 1m 46s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 57s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 34s | branch-1 passed |
| +0 :ok: | refguide | 4m 14s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 18s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 35s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 6s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 9s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 19m 30s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 58s | root in the patch failed. |
| +1 :green_heart: | compile | 1m 44s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 44s | the patch passed |
| +1 :green_heart: | javac | 1m 44s | the patch passed |
| -1 :x: | compile | 0m 48s | root in the patch failed with JDK v1.7.0_272. |
| -1 :x: | cc | 0m 48s | root in the patch failed with JDK v1.7.0_272. |
| -1 :x: | javac | 0m 48s | root in the patch failed with JDK v1.7.0_272. |
| -1 :x: | checkstyle | 0m 49s | hbase-client: The patch generated 2 new + 694 unchanged - 0 fixed = 696 total (was 694) |
| -1 :x: | checkstyle | 1m 57s | hbase-server: The patch generated 4 new + 655 unchanged - 0 fixed = 659 total (was 655) |
| -1 :x: | checkstyle | 6m 20s | root: The patch generated 6 new + 1358 unchanged - 0 fixed = 1364 total (was 1358) |
| -1 :x: | rubocop | 0m 18s | The patch generated 25 new + 829 unchanged - 1 fixed = 854 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 14s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| -1 :x: | shadedjars | 1m 13s | patch has 14 errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 0m 48s | The patch causes 14 errors with Hadoop v2.8.5. |
| -1 :x: | hadoopcheck | 1m 51s | The patch causes 14 errors with Hadoop v2.9.2. |
| -1 :x: | hbaseprotoc | 0m 20s | hbase-client in the patch failed. |
| -1 :x: | hbaseprotoc | 0m 33s | hbase-server in the patch failed. |
| -1 :x: | hbaseprotoc | 0m 33s | root in the patch failed. |
| -1 :x: | javadoc | 0m 19s | hbase-client-jdk1.8.0_262 with JDK v1.8.0_262 generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) |
| -1 :x: | javadoc | 0m 32s | hbase-server-jdk1.8.0_262 with JDK v1.8.0_262 generated 9 new + 8 unchanged - 0 fixed = 17 total (was 8) |
| -1 :x: | javadoc | 2m 8s | root-jdk1.8.0_262 with JDK v1.8.0_262 generated 10 new + 11 unchanged - 0 fixed = 21 total (was 11) |
| -1 :x: | javadoc | 0m 25s | hbase-client-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 14 unchanged - 0 fixed = 16 total (was 14) |
| -1 :x: | javadoc | 0m 44s | hbase-server-jdk1.7.0_272 with JDK v1.7.0_272 generated 9 new + 8 unchanged - 0 fixed = 17 total (was 8) |
| -1 :x: | javadoc | 4m 14s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 11 new + 15 unchanged - 0 fixed = 26 total (was 15) |
| -1 :x: | findbugs | 0m 20s | hbase-client in the patch failed. |
| -1 :x: | findbugs | 0m 30s | hbase-server in the patch failed. |
| -1 :x: | findbugs | 3m 35s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 7m 54s | root in the patch failed. |
| +1 :green_heart: | asflicense | 1m 11s | The patch does not generate ASF License warnings. |
| | | 131m 5s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux abe42307c4db 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / f0acafc |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/branch-site/book.html |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-compile-root-jdk1.7.0_272.txt |
| cc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-compile-root-jdk1.7.0_272.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-compile-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-site/book.html |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-shadedjars.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-javac-2.8.5.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-javac-2.9.2.txt |
| hbaseprotoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-hbaseprotoc-hbase-client.txt |
| hbaseprotoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-hbaseprotoc-hbase-server.txt |
| hbaseprotoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-hbaseprotoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/diff-javadoc-javadoc-hbase-server-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/diff-javadoc-javadoc-root-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/diff-javadoc-javadoc-hbase-server-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/diff-javadoc-javadoc-root-jdk1.7.0_272.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-findbugs-hbase-client.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-findbugs-hbase-server.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-findbugs-root.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/testReport/ |
| Max. process+thread count | 171 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/17/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on a change in pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#discussion_r506056833
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
##########
@@ -0,0 +1,154 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.slowlog;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.protobuf.generated.TooSlowLog;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Slowlog Accessor to record slow/large RPC log identified at each RegionServer RpcServer level.
+ * This can be done only optionally to record the entire history of slow/large rpc calls
+ * since RingBuffer can handle only limited latest records.
+ */
+@InterfaceAudience.Private
+public final class SlowLogTableAccessor {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SlowLogTableAccessor.class);
+
+ private static final Random RANDOM = new Random();
+
+ private static Connection connection;
+
+ private SlowLogTableAccessor() {
+ }
+
+ /**
+ * hbase:slowlog table name - can be enabled
+ * with config - hbase.regionserver.slowlog.systable.enabled
+ */
+ public static final TableName SLOW_LOG_TABLE_NAME =
+ TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "slowlog");
+
+ private static void doPut(final Connection connection, final List<Put> puts)
+ throws IOException {
+ try (Table table = connection.getTable(SLOW_LOG_TABLE_NAME)) {
Review comment:
This can be done afterwards.
So here I suggest, we should create something like TTL, if the connections hasn't been touched for a time, there then we close it, otherwise we should keep it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-681159308
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 14m 55s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 39s | branch-1 passed |
| +1 :green_heart: | compile | 2m 23s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 2m 21s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 14m 0s | branch-1 passed |
| +0 :ok: | refguide | 4m 12s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 24s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 15s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 7m 7s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 24s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 22m 10s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 38s | the patch passed |
| +1 :green_heart: | compile | 2m 25s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 2m 25s | the patch passed |
| +1 :green_heart: | javac | 2m 25s | the patch passed |
| +1 :green_heart: | compile | 2m 16s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 2m 16s | the patch passed |
| -1 :x: | javac | 2m 16s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 0m 54s | hbase-client: The patch generated 6 new + 625 unchanged - 3 fixed = 631 total (was 628) |
| -1 :x: | checkstyle | 2m 4s | hbase-server: The patch generated 9 new + 524 unchanged - 0 fixed = 533 total (was 524) |
| -1 :x: | checkstyle | 7m 4s | root: The patch generated 12 new + 1161 unchanged - 0 fixed = 1173 total (was 1161) |
| -1 :x: | rubocop | 0m 18s | The patch generated 19 new + 826 unchanged - 1 fixed = 845 total (was 827) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 53s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 32s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 50s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 5m 57s | the patch passed |
| +1 :green_heart: | javadoc | 4m 38s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 58s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 20m 42s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 177m 35s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 26s | The patch does not generate ASF License warnings. |
| | | 344m 42s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.master.TestWarmupRegion |
| | hadoop.hbase.namequeues.TestSlowLogAccessor |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux eb682495b9a8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / 8f946be |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/testReport/ |
| Max. process+thread count | 5058 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/4/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Reidddddd commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
Reidddddd commented on a change in pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#discussion_r506055382
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
##########
@@ -0,0 +1,154 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.slowlog;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.protobuf.generated.TooSlowLog;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Slowlog Accessor to record slow/large RPC log identified at each RegionServer RpcServer level.
+ * This can be done only optionally to record the entire history of slow/large rpc calls
+ * since RingBuffer can handle only limited latest records.
+ */
+@InterfaceAudience.Private
+public final class SlowLogTableAccessor {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SlowLogTableAccessor.class);
+
+ private static final Random RANDOM = new Random();
+
+ private static Connection connection;
+
+ private SlowLogTableAccessor() {
+ }
+
+ /**
+ * hbase:slowlog table name - can be enabled
+ * with config - hbase.regionserver.slowlog.systable.enabled
+ */
+ public static final TableName SLOW_LOG_TABLE_NAME =
+ TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "slowlog");
+
+ private static void doPut(final Connection connection, final List<Put> puts)
+ throws IOException {
+ try (Table table = connection.getTable(SLOW_LOG_TABLE_NAME)) {
+ table.put(puts);
+ }
+ }
+
+ /**
+ * Add slow/large log records to hbase:slowlog table
+ * @param slowLogPayloads List of SlowLogPayload to process
+ * @param configuration Configuration to use for connection
+ */
+ public static void addSlowLogRecords(final List<TooSlowLog.SlowLogPayload> slowLogPayloads,
+ final Configuration configuration) {
+ List<Put> puts = new ArrayList<>(slowLogPayloads.size());
+ for (TooSlowLog.SlowLogPayload slowLogPayload : slowLogPayloads) {
+ final byte[] rowKey = getRowKey(slowLogPayload);
+ final Put put = new Put(rowKey);
+ put.setDurability(Durability.SKIP_WAL);
+ put.setPriority(HConstants.NORMAL_QOS);
+ put.addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("call_details"),
+ Bytes.toBytes(slowLogPayload.getCallDetails()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("client_address"),
+ Bytes.toBytes(slowLogPayload.getClientAddress()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("method_name"),
+ Bytes.toBytes(slowLogPayload.getMethodName()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("param"),
+ Bytes.toBytes(slowLogPayload.getParam()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("processing_time"),
+ Bytes.toBytes(Integer.toString(slowLogPayload.getProcessingTime())))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("queue_time"),
+ Bytes.toBytes(Integer.toString(slowLogPayload.getQueueTime())))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("region_name"),
+ Bytes.toBytes(slowLogPayload.getRegionName()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("response_size"),
+ Bytes.toBytes(Long.toString(slowLogPayload.getResponseSize())))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("server_class"),
+ Bytes.toBytes(slowLogPayload.getServerClass()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("start_time"),
+ Bytes.toBytes(Long.toString(slowLogPayload.getStartTime())))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("type"),
+ Bytes.toBytes(slowLogPayload.getType().name()))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("username"),
+ Bytes.toBytes(slowLogPayload.getUserName()));
+ puts.add(put);
Review comment:
although it is back-port. I want to ask, why there's no table name included. From my experience, use region name to search table is very time-spending.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-680289180
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 44s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 2s | branch-1 passed |
| +1 :green_heart: | compile | 2m 8s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 2m 18s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 13m 57s | branch-1 passed |
| +0 :ok: | refguide | 5m 0s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 51s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 46s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 49s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 26s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 22m 33s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 23s | root in the patch failed. |
| +1 :green_heart: | compile | 2m 9s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 2m 9s | the patch passed |
| +1 :green_heart: | javac | 2m 9s | the patch passed |
| -1 :x: | compile | 1m 13s | root in the patch failed with JDK v1.7.0_272. |
| -1 :x: | cc | 1m 14s | root in the patch failed with JDK v1.7.0_272. |
| -1 :x: | javac | 1m 13s | root in the patch failed with JDK v1.7.0_272. |
| -1 :x: | checkstyle | 0m 50s | hbase-client: The patch generated 3 new + 628 unchanged - 0 fixed = 631 total (was 628) |
| -1 :x: | checkstyle | 2m 2s | hbase-server: The patch generated 10 new + 524 unchanged - 0 fixed = 534 total (was 524) |
| -1 :x: | checkstyle | 6m 54s | root: The patch generated 13 new + 1161 unchanged - 0 fixed = 1174 total (was 1161) |
| -1 :x: | rubocop | 0m 18s | The patch generated 19 new + 826 unchanged - 1 fixed = 845 total (was 827) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 58s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| -1 :x: | shadedjars | 2m 19s | patch has 16 errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 1m 20s | The patch causes 16 errors with Hadoop v2.8.5. |
| -1 :x: | hadoopcheck | 3m 29s | The patch causes 16 errors with Hadoop v2.9.2. |
| -1 :x: | hbaseprotoc | 0m 39s | hbase-server in the patch failed. |
| -1 :x: | hbaseprotoc | 1m 2s | root in the patch failed. |
| +1 :green_heart: | javadoc | 4m 13s | the patch passed with JDK v1.8.0_262 |
| -1 :x: | javadoc | 0m 46s | hbase-server-jdk1.7.0_272 with JDK v1.7.0_272 generated 1 new + 8 unchanged - 0 fixed = 9 total (was 8) |
| -1 :x: | javadoc | 4m 41s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) |
| -1 :x: | findbugs | 0m 40s | hbase-server in the patch failed. |
| -1 :x: | findbugs | 6m 33s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 11m 58s | root in the patch failed. |
| +1 :green_heart: | asflicense | 1m 16s | The patch does not generate ASF License warnings. |
| | | 156m 18s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 1e5af65ea2a9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / 8f946be |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/branch-site/book.html |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-compile-root-jdk1.7.0_272.txt |
| cc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-compile-root-jdk1.7.0_272.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-compile-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-site/book.html |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-shadedjars.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-javac-2.8.5.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-javac-2.9.2.txt |
| hbaseprotoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-hbaseprotoc-hbase-server.txt |
| hbaseprotoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-hbaseprotoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/diff-javadoc-javadoc-hbase-server-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/diff-javadoc-javadoc-root-jdk1.7.0_272.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-findbugs-hbase-server.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-findbugs-root.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/testReport/ |
| Max. process+thread count | 233 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-698407220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-680713882
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 6m 12s | Docker failed to build yetus/hbase:b249092a5f. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/2/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-689724793
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 24s | branch-1 passed |
| +1 :green_heart: | compile | 2m 5s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 2m 14s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 14m 19s | branch-1 passed |
| +0 :ok: | refguide | 5m 5s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 31s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 19s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 47s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 21s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 22m 37s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 20s | the patch passed |
| +1 :green_heart: | compile | 2m 7s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 2m 7s | the patch passed |
| +1 :green_heart: | javac | 2m 7s | the patch passed |
| +1 :green_heart: | compile | 2m 16s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 2m 16s | the patch passed |
| -1 :x: | javac | 2m 16s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 0m 45s | hbase-client: The patch generated 8 new + 625 unchanged - 3 fixed = 633 total (was 628) |
| -1 :x: | checkstyle | 6m 48s | root: The patch generated 8 new + 1158 unchanged - 3 fixed = 1166 total (was 1161) |
| -1 :x: | rubocop | 0m 22s | The patch generated 19 new + 829 unchanged - 1 fixed = 848 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 42s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 28s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 5m 6s | the patch passed |
| -1 :x: | javadoc | 0m 25s | hbase-client-jdk1.8.0_262 with JDK v1.8.0_262 generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) |
| -1 :x: | javadoc | 2m 44s | root-jdk1.8.0_262 with JDK v1.8.0_262 generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11) |
| -1 :x: | javadoc | 0m 34s | hbase-client-jdk1.7.0_272 with JDK v1.7.0_272 generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) |
| -1 :x: | javadoc | 4m 40s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) |
| +1 :green_heart: | findbugs | 24m 27s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 193m 43s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 23s | The patch does not generate ASF License warnings. |
| | | 350m 1s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.master.TestMasterBalanceThrottling |
| | hadoop.hbase.client.TestAdmin2 |
| | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 2ea2410ae3f8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / e5c0a94 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/patch-site/book.html |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/diff-javadoc-javadoc-root-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.7.0_272.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/diff-javadoc-javadoc-root-jdk1.7.0_272.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/testReport/ |
| Max. process+thread count | 4754 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/11/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks) to branch-1
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#discussion_r505965769
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -430,7 +440,7 @@ protected boolean needsBalance(Cluster cluster) {
System.arraycopy(tempFunctionCosts, 0, curFunctionCosts, 0, this.curFunctionCosts.length);
double initCost = currentCost;
- double newCost = currentCost;
+ double newCost;
Review comment:
What happened here? Seems like an extraneous change and maybe wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2312:
URL: https://github.com/apache/hbase/pull/2312#issuecomment-695211934
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 12m 52s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 14s | branch-1 passed |
| +1 :green_heart: | compile | 1m 52s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 56s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 59s | branch-1 passed |
| +0 :ok: | refguide | 4m 27s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 24s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 17s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 52s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 56s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 20m 21s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 5s | the patch passed |
| +1 :green_heart: | compile | 1m 46s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 46s | the patch passed |
| +1 :green_heart: | javac | 1m 46s | the patch passed |
| +1 :green_heart: | compile | 1m 54s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 54s | the patch passed |
| -1 :x: | javac | 1m 54s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) |
| -1 :x: | checkstyle | 6m 38s | root: The patch generated 3 new + 1355 unchanged - 3 fixed = 1358 total (was 1358) |
| -1 :x: | rubocop | 0m 19s | The patch generated 25 new + 829 unchanged - 1 fixed = 854 total (was 830) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 2 ill-formed XML file(s). |
| +0 :ok: | refguide | 3m 26s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 3m 5s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 3s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 41s | the patch passed |
| +1 :green_heart: | javadoc | 3m 47s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 4s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 21m 13s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 11m 3s | root in the patch failed. |
| +1 :green_heart: | asflicense | 1m 18s | The patch does not generate ASF License warnings. |
| | | 164m 27s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-common/src/main/resources/hbase-default.xml |
| | hbase-protocol/pom.xml |
| Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/20/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2312 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop |
| uname | Linux 139d371833ea 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2312/out/precommit/personality/provided.sh |
| git revision | branch-1 / e1fc3c4 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/20/artifact/out/branch-site/book.html |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/20/artifact/out/diff-compile-javac-root-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/20/artifact/out/diff-checkstyle-root.txt |
| rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/20/artifact/out/diff-patch-rubocop.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/20/artifact/out/xml.txt |
| refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/20/artifact/out/patch-site/book.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/20/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/20/testReport/ |
| Max. process+thread count | 171 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-shell . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/20/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 rubocop=0.81.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org