You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org> on 2018/06/08 00:46:08 UTC
[Impala-ASF-CR] IMPALA-7149: Skip q7 in test mem usage scaling in erasure coding build
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10647
Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build
......................................................................
IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build
The test is flaky in the erasure coding build. Let's disable it for now.
Change-Id: Ic9a34a91eef40e1da9c7134cfb7054006d9115de
---
M tests/query_test/test_mem_usage_scaling.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/10647/1
--
To view, visit http://gerrit.cloudera.org:8080/10647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9a34a91eef40e1da9c7134cfb7054006d9115de
Gerrit-Change-Number: 10647
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-7149: Skip q7 in test mem usage scaling in erasure coding build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10647 )
Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a34a91eef40e1da9c7134cfb7054006d9115de
Gerrit-Change-Number: 10647
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jun 2018 04:15:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7149: Skip q7 in test mem usage scaling in erasure coding build
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10647 )
Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build
......................................................................
Patch Set 1: Code-Review+2
It seems only the query memory limit is exceeded. In that case disabling this query is fine.
--
To view, visit http://gerrit.cloudera.org:8080/10647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a34a91eef40e1da9c7134cfb7054006d9115de
Gerrit-Change-Number: 10647
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jun 2018 00:52:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7149: Skip q7 in test mem usage scaling in erasure coding build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10647 )
Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build
......................................................................
IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build
The test is flaky in the erasure coding build. Let's disable it for now.
Change-Id: Ic9a34a91eef40e1da9c7134cfb7054006d9115de
Reviewed-on: http://gerrit.cloudera.org:8080/10647
Reviewed-by: Tianyi Wang <tw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_mem_usage_scaling.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tianyi Wang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9a34a91eef40e1da9c7134cfb7054006d9115de
Gerrit-Change-Number: 10647
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-7149: Skip q7 in test mem usage scaling in erasure coding build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10647 )
Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2624/
--
To view, visit http://gerrit.cloudera.org:8080/10647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a34a91eef40e1da9c7134cfb7054006d9115de
Gerrit-Change-Number: 10647
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jun 2018 00:55:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7149: Skip q7 in test mem usage scaling in erasure coding build
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10647 )
Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10647/2/tests/query_test/test_mem_usage_scaling.py
File tests/query_test/test_mem_usage_scaling.py:
http://gerrit.cloudera.org:8080/#/c/10647/2/tests/query_test/test_mem_usage_scaling.py@35
PS2, Line 35: @SkipIfNotHdfsMinicluster.tuned_for_minicluster
What is the purpose of running this test for EC? What test coverage is this providing? Do we expect the memory consumption to be exactly the same for EC as for HDFS, given that it's still fairly timing-dependent.
The background is that this test was tuned for the 3-node minicluster and tested for a while in that configuration to make sure it isn't flaky. I've tagged tests like that with the above decorator so that we don't run them in alternative configurations, and I'm not sure that carrying these tests over to EC is the right thing.
--
To view, visit http://gerrit.cloudera.org:8080/10647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a34a91eef40e1da9c7134cfb7054006d9115de
Gerrit-Change-Number: 10647
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jun 2018 15:58:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7149: Skip q7 in test mem usage scaling in erasure coding build
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10647 )
Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10647/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10647/2//COMMIT_MSG@9
PS2, Line 9: The test is flaky in the erasure coding build. Let's disable it for now.
This broke the 2.x cherry-picking.
12:19:08 E ImportError: cannot import name SkipIfEC
--
To view, visit http://gerrit.cloudera.org:8080/10647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a34a91eef40e1da9c7134cfb7054006d9115de
Gerrit-Change-Number: 10647
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jun 2018 15:53:23 +0000
Gerrit-HasComments: Yes