[jira] Closed: (MPDEPLOY-4) Incorrect arguments in jar:deploy and jar:deploy-snapshot

[ji...@codehaus.org]

Message:

   The following issue has been closed.

   Resolver: Brett Porter
       Date: Fri, 25 Jun 2004 11:32 AM

jar now uses artifact plugin.
artifact may be absolute, however legacy deploy method (external scp) will fail if it is not relative to basedir.
artifact itself should be fine.
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPDEPLOY-4

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPDEPLOY-4
    Summary: Incorrect arguments in jar:deploy and jar:deploy-snapshot
       Type: Bug

     Status: Closed
   Priority: Major
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-deploy-plugin

   Assignee: 
   Reporter: Aslak Hellesoy

    Created: Fri, 4 Apr 2003 6:31 AM
    Updated: Fri, 25 Jun 2004 11:32 AM

Description:
The jar:deploy and jar:deploy-snapshot goals are doing some fancy and unnecessary string manipulations to find the relative file name of the jar file to deploy.

This is unnecessary (the file name of the jars can be absolute), and furhter, it doesn't work when ${maven.build.dir} is overridden to point outside the project.

Further, the jar:deploy-snapshot could just call the jar:deploy goal (and avoid copy-paste of identical logic).

The mentioned goals should be simplified as follows:

  <!-- ================================================================== -->
  <!-- D E P L O Y  S N A P S H O T                                       -->
  <!-- ================================================================== -->

  <goal
    name="jar:deploy-snapshot"
    description="Deploy a snapshot jar to the remote repository">

    <m:user-check user="${maven.username}"/>
    <attainGoal name="jar:snapshot"/>
    <attainGoal name="jar:deploy"/>
                    
  </goal>

  <!-- ================================================================== -->
  <!-- D E P L O Y  J A R                                                 -->
  <!-- ================================================================== -->

  <goal
    name="jar:deploy"
    description="Deploy a jar to the remote repository">

    <m:user-check user="${maven.username}"/>
    <attainGoal name="java:jar"/>
    <ant:property name="maven.jar.to.deploy" value="${maven.final.name}.jar"/>
    <deploy:artifact
      artifact="${maven.final.name}.jar"
      type="jars"
      assureDirectoryCommand="mkdir -p"
      siteCommand="cd @deployDirectory@; chmod g+w ${maven.jar.to.deploy}; chgrp maven ${maven.jar.to.deploy}"
    />

  </goal>



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org