You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/01 11:03:54 UTC

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #8448: Agent code optimize

terrymanu commented on a change in pull request #8448:
URL: https://github.com/apache/shardingsphere/pull/8448#discussion_r533323351



##########
File path: shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/exception/PluginDefineNotFoundException.java
##########
@@ -19,7 +19,17 @@
 package org.apache.shardingsphere.agent.core.exception;
 
 /**
- * Advice not found exception.
+ * Plugin define not found exception.
  */
-public class AdviceNotFoundException extends RuntimeException {
+public class PluginDefineNotFoundException extends RuntimeException {
+    
+    /**
+     * Constructs an exception with formatted error message and arguments.
+     *
+     * @param errorMessage formatted error message
+     * @param args arguments of error message
+     */
+    public PluginDefineNotFoundException(final String errorMessage, final Object... args) {

Review comment:
       PluginDefineNotFoundException should be changed to PluginDefinitionNotFoundException




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org