You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "jinxxxoid (via GitHub)" <gi...@apache.org> on 2025/07/07 08:49:58 UTC
[PR] IGNITE-25845 SSL support for ODBC Driver [ignite-3]
jinxxxoid opened a new pull request, #6202:
URL: https://github.com/apache/ignite-3/pull/6202
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25845 SSL support for ODBC Driver [ignite-3]
Posted by "isapego (via GitHub)" <gi...@apache.org>.
isapego commented on code in PR #6202:
URL: https://github.com/apache/ignite-3/pull/6202#discussion_r2194292896
##########
docs/_docs/developers-guide/sql/odbc/connection-string.adoc:
##########
@@ -70,6 +70,22 @@ This argument value is ignored if `ADDRESS` argument is specified.
|Number of rows returned in response to a fetching request to the data source. Default value should be fine in most cases. Setting a low value can result in slow data fetching while setting a high value can result in additional memory usage by the driver, and additional delay when the next page is being retrieved.
|`1024`
+|`SSL_MODE`
+|Determines whether the SSL connection should be negotiated with the server. Use `require` or `disable` mode as needed.
+|None.
Review Comment:
Default is 'disable'
##########
docs/_docs/developers-guide/sql/odbc/connection-string.adoc:
##########
@@ -70,6 +70,22 @@ This argument value is ignored if `ADDRESS` argument is specified.
|Number of rows returned in response to a fetching request to the data source. Default value should be fine in most cases. Setting a low value can result in slow data fetching while setting a high value can result in additional memory usage by the driver, and additional delay when the next page is being retrieved.
|`1024`
+|`SSL_MODE`
+|Determines whether the SSL connection should be negotiated with the server. Use `require` or `disable` mode as needed.
+|None.
+
+|`SSL_KEY_FILE`
+|Specifies the name of the file containing the SSL server private key.
Review Comment:
```suggestion
|Specifies the path to the file containing the SSL server private key.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25845 SSL support for ODBC Driver [ignite-3]
Posted by "isapego (via GitHub)" <gi...@apache.org>.
isapego merged PR #6202:
URL: https://github.com/apache/ignite-3/pull/6202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org