[hbase] branch branch-1 updated: HBASE-21905 (addendum): Address compaction races in TestFIFOCompactionPolicy (#2203)

[bh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

bharathv pushed a commit to branch branch-1
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-1 by this push:
     new 839ce8e  HBASE-21905 (addendum): Address compaction races in TestFIFOCompactionPolicy (#2203)
839ce8e is described below

commit 839ce8e5607a4796e1d742c4e73e93f5f602cef2
Author: Bharath Vissapragada <bh...@apache.org>
AuthorDate: Thu Aug 6 09:31:41 2020 -0700

    HBASE-21905 (addendum): Address compaction races in TestFIFOCompactionPolicy (#2203)
    
    Looped through the test 100 times and it passes. Without the patch it fails
    every ~10 runs or so.
    
    Signed-off-by: Viraj Jasani <vj...@apache.org>
    Signed-off-by: Michael Stack <st...@apache.org>
---
 .../hbase/regionserver/compactions/TestFIFOCompactionPolicy.java     | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java
index 3f9bc65..46b44a1 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java
@@ -115,6 +115,11 @@ public class TestFIFOCompactionPolicy {
     EnvironmentEdgeManager.injectEdge(ee);
     Configuration conf = TEST_UTIL.getConfiguration();
     conf.setInt(HStore.BLOCKING_STOREFILES_KEY, 10000);
+    // Expired store file deletion during compaction optimization interferes with the FIFO
+    // compaction policy. The race causes changes to in-flight-compaction files resulting in a
+    // non-deterministic number of files selected by compaction policy. Disables that optimization
+    // for this test run.
+    conf.setBoolean("hbase.store.delete.expired.storefile", false);
     TEST_UTIL.startMiniCluster(1);
   }