[jira] [Commented] (HDFS-5758) NameNode: complete implementation of inode modifications for ACLs.

["Haohui Mai (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873815#comment-13873815 ] 

Haohui Mai commented on HDFS-5758:
----------------------------------

It seems to me that you can enforce the permission by the following:

{code}
isAccessAllowed():

checkFsPermission();

if (hasAcl) {
decide whether acl allows the access
}
{code}

I'm not sure why AclStorage#updateINodeAcl and AclStorage#readINodeAcl need to construct entries from the old permissions.

> NameNode: complete implementation of inode modifications for ACLs.
> ------------------------------------------------------------------
>
>                 Key: HDFS-5758
>                 URL: https://issues.apache.org/jira/browse/HDFS-5758
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5758.1.patch, HDFS-5758.2.patch
>
>
> This patch will complete the remaining logic for the ACL get and set APIs, including remaining work in {{FSNamesystem}}, {{FSDirectory}} and storage in the inodes.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)