You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2024/05/20 08:38:33 UTC
[PR] [#1721] fix(coordinator): classCastExpection of boolean->String with yaml style remote client conf [incubator-uniffle]
zuston opened a new pull request, #1722:
URL: https://github.com/apache/incubator-uniffle/pull/1722
### What changes were proposed in this pull request?
fix classCastExpection of boolean->String with yaml style remote client conf
### Why are the changes needed?
Fix: #1721
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1721] fix(coordinator): classCastExpection of boolean->String with yaml style remote client conf [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1722:
URL: https://github.com/apache/incubator-uniffle/pull/1722#issuecomment-2119973878
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1722?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 54.01%. Comparing base [(`6f6d35a`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/6f6d35aab8e9fe7002de3768e6d5a30cad2d4cb7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`bedaf04`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1722?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 25 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1722 +/- ##
============================================
- Coverage 54.86% 54.01% -0.85%
- Complexity 2358 2531 +173
============================================
Files 368 393 +25
Lines 16379 18421 +2042
Branches 1504 1665 +161
============================================
+ Hits 8986 9951 +965
- Misses 6862 7909 +1047
- Partials 531 561 +30
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1722?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1721] fix(coordinator): classCastExpection of boolean->String with yaml style remote client conf [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1722:
URL: https://github.com/apache/incubator-uniffle/pull/1722#issuecomment-2124023162
> @zuston Could you commit this to branch 0.9?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1721] fix(coordinator): classCastExpection of boolean->String with yaml style remote client conf [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1722:
URL: https://github.com/apache/incubator-uniffle/pull/1722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1721] fix(coordinator): classCastExpection of boolean->String with yaml style remote client conf [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1722:
URL: https://github.com/apache/incubator-uniffle/pull/1722#issuecomment-2121583652
@zuston Could you commit this to branch 0.9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1721] fix(coordinator): classCastExpection of boolean->String with yaml style remote client conf [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1722:
URL: https://github.com/apache/incubator-uniffle/pull/1722#issuecomment-2120003185
## Test Results
2 404 files - 1 2 404 suites - 1 4h 56m 59s :stopwatch: - 1m 19s
931 tests ±0 929 :white_check_mark: - 1 1 :zzz: ±0 0 :x: ±0 1 :fire: +1
10 790 runs - 1 10 775 :white_check_mark: - 2 14 :zzz: ±0 0 :x: ±0 1 :fire: +1
For more details on these errors, see [this check](https://github.com/apache/incubator-uniffle/runs/25170207992).
Results for commit bedaf04f. ± Comparison against base commit c3cbdec4.
[test-results]:data:application/gzip;base64,H4sIAH0RS2YC/03MQQ6DIBCF4asY1l0MigK9TIMDk5CqNAirpncvNGpZvo/hfzPyi9vZvesFiFvH9uxTu22OJvmwFeFScV2ovKd6oQd+rseeESv1+k9P/6q/LiDjlwJwgYsxxOMk5q02OUgNxzyjxeR42VEVJzTV326jGNbVpzLY7KwhEISoEYwdZ+kUcUVIk7GDAD5aNUzYs88X0dDi8xIBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org