You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/06 05:27:03 UTC

[GitHub] [pulsar] gaozhangmin commented on pull request #15465: [improve][client] improve logic when ACK grouping tracker checks duplicated message id

gaozhangmin commented on PR #15465:
URL: https://github.com/apache/pulsar/pull/15465#issuecomment-1119271585

   > I am sorrry but I don't understanding the benefit of this patch. We are not saving CPU cycles or fixing a bug.
   > 
   > Usually it is better to not change the code if there isn't a clear benefit. 'Don't fix things that are not broken'
   
   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org