You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/09/05 20:51:06 UTC
Re: Review Request 60546: Harden Mesos when building with cmake.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60546/#review184580
-----------------------------------------------------------
Ship it!
I'm going to apply this review in spirit (because the CMake build was rewritten underneath it).
I'll make the below changes before committing.
cmake/CompilationConfigure.cmake
Lines 202-212 (patched)
<https://reviews.apache.org/r/60546/#comment260749>
Going to replace this:
`set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} `
With this:
`string(APPEND CMAKE_CXX_FLAGS " `
cmake/CompilationConfigure.cmake
Lines 219-223 (patched)
<https://reviews.apache.org/r/60546/#comment260747>
Going to replace this with the cross-platform equivalent:
```
set(CMAKE_POSITION_INDEPENDENT_CODE TRUE)
```
See: https://cmake.org/cmake/help/v3.0/prop_tgt/POSITION_INDEPENDENT_CODE.html
cmake/MesosConfigure.cmake
Lines 65-70 (patched)
<https://reviews.apache.org/r/60546/#comment260748>
Ditto with above.
- Joseph Wu
On July 5, 2017, 9:06 a.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60546/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 9:06 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.
>
>
> Bugs: MESOS-7737
> https://issues.apache.org/jira/browse/MESOS-7737
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Apply stack protectors (stronger stack protectors with newer compilers), position independent code suitable for linking into executables, security warnings, and generate position independent executables.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 3fa2e2f3b
> cmake/MesosConfigure.cmake 5ecad2c0f
>
>
> Diff: https://reviews.apache.org/r/60546/diff/2/
>
>
> Testing
> -------
>
> `mkdir build && cd build && cmake .. && make -j$(nproc) && make check -j$(nproc)`
>
>
> Thanks,
>
> Aaron Wood
>
>