You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/06/02 21:31:24 UTC
[GitHub] [trafficcontrol] rawlinp opened a new pull request #5907: Fix postinstall issues for new Traffic Vault PostgreSQL config
rawlinp opened a new pull request #5907:
URL: https://github.com/apache/trafficcontrol/pull/5907
## What does this PR (Pull Request) do?
Make the new Traffic Vault PostgreSQL questions optional and clean up
some minor issues with questions that were unused. Additionally, move
default aes.key location to TO conf dir.
## Which Traffic Control components are affected by this PR?
- CDN in a Box
- Traffic Vault
## What is the best way to verify this PR?
Start up CiaB, ensure it starts up successfully (indicating that postinstall ran successfully). Run `postinstall.test.sh`, ensure it passes successfully.
## The following criteria are ALL met by this PR
- [x] This PR includes tests
- [x] postinstall fix, no docs necessary
- [x] no changelog necessary (TV Postgres backend addition already covered)
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5907: Fix postinstall issues for new Traffic Vault PostgreSQL config
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5907:
URL: https://github.com/apache/trafficcontrol/pull/5907#discussion_r644359848
##########
File path: traffic_ops/install/bin/_postinstall
##########
@@ -737,7 +729,7 @@ def write_encryption_key(aes_key_location): # type: (str) -> None
"-base64",
"32"
)
- if not exec_openssl("Generating an AES encryption key", *args):
+ if not exec_openssl("Generating an AES encryption key to %s" %aes_key_location, *args):
Review comment:
The string modulo operator is outdated, this should use `.format()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #5907: Fix postinstall issues for new Traffic Vault PostgreSQL config
Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #5907:
URL: https://github.com/apache/trafficcontrol/pull/5907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5907: Fix postinstall issues for new Traffic Vault PostgreSQL config
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #5907:
URL: https://github.com/apache/trafficcontrol/pull/5907#discussion_r644401358
##########
File path: traffic_ops/install/bin/_postinstall
##########
@@ -737,7 +729,7 @@ def write_encryption_key(aes_key_location): # type: (str) -> None
"-base64",
"32"
)
- if not exec_openssl("Generating an AES encryption key", *args):
+ if not exec_openssl("Generating an AES encryption key to %s" %aes_key_location, *args):
Review comment:
maybe I'm just old school 😎
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5907: Fix postinstall issues for new Traffic Vault PostgreSQL config
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5907:
URL: https://github.com/apache/trafficcontrol/pull/5907#discussion_r644359848
##########
File path: traffic_ops/install/bin/_postinstall
##########
@@ -737,7 +729,7 @@ def write_encryption_key(aes_key_location): # type: (str) -> None
"-base64",
"32"
)
- if not exec_openssl("Generating an AES encryption key", *args):
+ if not exec_openssl("Generating an AES encryption key to %s" %aes_key_location, *args):
Review comment:
The string modulo operator is outdated, this should use `.format()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #5907: Fix postinstall issues for new Traffic Vault PostgreSQL config
Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #5907:
URL: https://github.com/apache/trafficcontrol/pull/5907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5907: Fix postinstall issues for new Traffic Vault PostgreSQL config
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #5907:
URL: https://github.com/apache/trafficcontrol/pull/5907#discussion_r644401358
##########
File path: traffic_ops/install/bin/_postinstall
##########
@@ -737,7 +729,7 @@ def write_encryption_key(aes_key_location): # type: (str) -> None
"-base64",
"32"
)
- if not exec_openssl("Generating an AES encryption key", *args):
+ if not exec_openssl("Generating an AES encryption key to %s" %aes_key_location, *args):
Review comment:
maybe I'm just old school 😎
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org