You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "ktoublanc (via GitHub)" <gi...@apache.org> on 2024/09/04 09:55:20 UTC
[PR] feat: add deployment URL mapping to webhook plugin [incubator-devlake]
ktoublanc opened a new pull request, #8000:
URL: https://github.com/apache/incubator-devlake/pull/8000
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Summary
This PR add mapping for deployment URL when creating a deployment through web hook plugin.
I did not see any relevant tests for the web hook plugin but I am willing to contribute as to this as I'm planning to propose other changes (a fix on the deployment name computation which can exceed 255 chars when multiple commits are present and the ability to delete issues created from the web hook)
### Does this close any open issues?
No open issues for this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add deployment URL mapping to webhook plugin [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #8000:
URL: https://github.com/apache/incubator-devlake/pull/8000#issuecomment-2342878961
LGTM.
Don't forget to write a migration script to add the column to the database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add deployment URL mapping to webhook plugin [incubator-devlake]
Posted by "ktoublanc (via GitHub)" <gi...@apache.org>.
ktoublanc commented on PR #8000:
URL: https://github.com/apache/incubator-devlake/pull/8000#issuecomment-2357838514
@klesh did you have time to check my last comment ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add deployment URL mapping to webhook plugin [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #8000:
URL: https://github.com/apache/incubator-devlake/pull/8000#issuecomment-2359893640
Merged, thanks for your contribution. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add deployment URL mapping to webhook plugin [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #8000:
URL: https://github.com/apache/incubator-devlake/pull/8000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add deployment URL mapping to webhook plugin [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #8000:
URL: https://github.com/apache/incubator-devlake/pull/8000#issuecomment-2359889173
@ktoublanc You're absolutely right. I wasn't aware that the field already existed—thank you for the clarification!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add deployment URL mapping to webhook plugin [incubator-devlake]
Posted by "ktoublanc (via GitHub)" <gi...@apache.org>.
ktoublanc commented on PR #8000:
URL: https://github.com/apache/incubator-devlake/pull/8000#issuecomment-2342960456
> LGTM. Don't forget to write a migration script to add the column to the database.
Hey, thanks for the review.
I don't get what migration script I should write...
From my point of view, I'm only adding a field in the Webhook API which will value the Url field of the deployment model.
This field is already created in the database (cicd_deployments.url) which is nullable and I can't set a default value for the field and there are no associated _tool_webhook_... table associated.
Am I getting it right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org