You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/11/05 02:21:52 UTC
[GitHub] [solr] magibney commented on pull request #385: SOLR-15760: Improve the default distributed facet overrequest function/heuristic
magibney commented on pull request #385:
URL: https://github.com/apache/solr/pull/385#issuecomment-961576928
The condition on small offset was added in 1f7777693769bad1cd8fc40b339d00c43f16f9d1, and I think in a pinch this could stand to simply be removed (to restore the initial unconditional linear overrequest boost according to the overrequest function `f(x)=1.1*x + 4`, initially introduced in 7b5df8a10391f5b824e8ea1793917ff60b64b8a8).
@dsmiley, could you take a quick look at this? I think there's some sense to the assertion that larger numbers of requested values actually need _less_ overrequest (though I still don't think the distinction between offset and limit is relevant). Intuitively I'd also think that perhaps we'd want to boost extremely low gross-limit requests by _more_ than 4 (the proposal currently in this PR has a floor of 12 for shard requests).
Ultimately I think there a three options that might make sense:
1. revert the overrequest function change from 1f7777693769bad1cd8fc40b339d00c43f16f9d1, going back to the original, unconditional linear boost
2. change to a function something like what's proposed in this PR, which decays for larger gross limits
3. switch to a static additive boost (+12 or something) that would help small requests, and "decay" (relative to the overall requested size) for higher gross limits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org