You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Ivan Kelly <iv...@apache.org> on 2012/05/16 17:48:50 UTC
Review Request: BOOKKEEPER-146 TestConcurrentTopicAcquisition sometimes hangs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5144/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
It's been running in a loop for 30 minutes now, and doesn't seem to be hanging. Main problem was that even after the hedwig client was closed, a subscription request could succeed and add a channel to the channel list, though hedwig client had already moved by the point at which it closed them.
This addresses bug BOOKKEEPER-146.
https://issues.apache.org/jira/browse/BOOKKEEPER-146
Diffs
-----
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java 0c8634c
hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java a8552f4
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java 603766c
hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java f5077b0
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClientImpl.java 806cdef
Diff: https://reviews.apache.org/r/5144/diff
Testing
-------
Thanks,
Ivan
Re: Review Request: BOOKKEEPER-146 TestConcurrentTopicAcquisition sometimes
hangs
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5144/#review7950
-----------------------------------------------------------
thanks Ivan. the patch seems great. just some slight comments.
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java
<https://reviews.apache.org/r/5144/#comment17288>
it would be better to move line 'closed = true;' to the top of close(). because you used closed to avoid new channel being storeHost2ChannelMapping.
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java
<https://reviews.apache.org/r/5144/#comment17289>
do we need to put the closing logic in closeLock synchronization block?
if we had acquired closeLock and set closed to true, no channel could be put into topicSubscriber2Channel again.
- Sijie
On 2012-05-16 15:48:50, Ivan Kelly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5144/
> -----------------------------------------------------------
>
> (Updated 2012-05-16 15:48:50)
>
>
> Review request for bookkeeper.
>
>
> Summary
> -------
>
> It's been running in a loop for 30 minutes now, and doesn't seem to be hanging. Main problem was that even after the hedwig client was closed, a subscription request could succeed and add a channel to the channel list, though hedwig client had already moved by the point at which it closed them.
>
>
> This addresses bug BOOKKEEPER-146.
> https://issues.apache.org/jira/browse/BOOKKEEPER-146
>
>
> Diffs
> -----
>
> hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java 0c8634c
> hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java a8552f4
> hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java 603766c
> hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java f5077b0
> hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClientImpl.java 806cdef
>
> Diff: https://reviews.apache.org/r/5144/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ivan
>
>
Re: Review Request: BOOKKEEPER-146 TestConcurrentTopicAcquisition sometimes
hangs
Posted by Ivan Kelly <iv...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5144/
-----------------------------------------------------------
(Updated 2012-05-17 17:49:36.598125)
Review request for bookkeeper.
Summary
-------
It's been running in a loop for 30 minutes now, and doesn't seem to be hanging. Main problem was that even after the hedwig client was closed, a subscription request could succeed and add a channel to the channel list, though hedwig client had already moved by the point at which it closed them.
This addresses bug BOOKKEEPER-146.
https://issues.apache.org/jira/browse/BOOKKEEPER-146
Diffs (updated)
-----
hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java f5077b0
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClientImpl.java 806cdef
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java 603766c
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java 0c8634c
hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java a8552f4
Diff: https://reviews.apache.org/r/5144/diff
Testing
-------
Thanks,
Ivan