You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/01/15 02:36:59 UTC
Re: Review Request 13606: Added a Top abstraction to the webui.
> On Aug. 16, 2013, 6:54 p.m., Ross Allen wrote:
> > src/webui/master/static/js/controllers.js, line 636
> > <https://reviews.apache.org/r/13606/diff/1/?file=341590#file341590line636>
> >
> > These `if (!$scope.monitor)` blocks can be handled in the Top service.
Ross and I added a started() call here rather than relying on the $scope.monitor.
> On Aug. 16, 2013, 6:54 p.m., Ross Allen wrote:
> > src/webui/master/static/slave.html, line 177
> > <https://reviews.apache.org/r/13606/diff/1/?file=341591#file341591line177>
> >
> > This division should be moved to the statistics object as well.
This is not a division, although it looks like one. :)
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13606/#review25244
-----------------------------------------------------------
On Aug. 15, 2013, 10:14 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13606/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 10:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This adds a Top abstraction to the webui for periodically polling the monitoring endpoint.
>
> Instead of having each controller have to deal with monitoring information during the update cycle, this allows each controller to setup asynchronous monitoring updates, stopping it when the controller becomes inactive.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 305aeaa195183c188e8ed949ccd67b49cbd757a0
> src/webui/master/static/slave.html e1dabc0b04dec404a0aabd52d0387a0af70ad40d
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
>
> Diff: https://reviews.apache.org/r/13606/diff/
>
>
> Testing
> -------
>
> Ran the long-lived-framework.
>
>
> Thanks,
>
> Ben Mahler
>
>