You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Douglas Creager (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 21:30:22 UTC
[jira] [Created] (AVRO-1048) C data file writer uses too much stack
space
C data file writer uses too much stack space
--------------------------------------------
Key: AVRO-1048
URL: https://issues.apache.org/jira/browse/AVRO-1048
Project: Avro
Issue Type: Bug
Components: c
Affects Versions: 1.6.3
Reporter: Douglas Creager
Assignee: Douglas Creager
The avro_file_writer code in the C bindings allocate a large (64K) buffer on the stack. This causes (very) hard-to-diagnose bugs if you try to output a data file from within a function with limited stack space. (For instance, if you're running inside of a coroutine or thread with a 64K stack...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AVRO-1048) C data file writer uses too much
stack space
Posted by "Douglas Creager (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Douglas Creager resolved AVRO-1048.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.7.0
Committed to SVN
> C data file writer uses too much stack space
> --------------------------------------------
>
> Key: AVRO-1048
> URL: https://issues.apache.org/jira/browse/AVRO-1048
> Project: Avro
> Issue Type: Bug
> Components: c
> Affects Versions: 1.6.3
> Reporter: Douglas Creager
> Assignee: Douglas Creager
> Fix For: 1.7.0
>
> Attachments: 0001-AVRO-1048.-C-Use-less-stack-space-in-avro_file_write.patch
>
>
> The avro_file_writer code in the C bindings allocate a large (64K) buffer on the stack. This causes (very) hard-to-diagnose bugs if you try to output a data file from within a function with limited stack space. (For instance, if you're running inside of a coroutine or thread with a 64K stack...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1048) C data file writer uses too much stack
space
Posted by "Douglas Creager (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Douglas Creager updated AVRO-1048:
----------------------------------
Attachment: 0001-AVRO-1048.-C-Use-less-stack-space-in-avro_file_write.patch
This patch moves the scratch buffer into the avro_file_writer instance itself; we're already allocating that from the heap, and it's easy enough to add the 64K buffer to the end of the type.
> C data file writer uses too much stack space
> --------------------------------------------
>
> Key: AVRO-1048
> URL: https://issues.apache.org/jira/browse/AVRO-1048
> Project: Avro
> Issue Type: Bug
> Components: c
> Affects Versions: 1.6.3
> Reporter: Douglas Creager
> Assignee: Douglas Creager
> Attachments: 0001-AVRO-1048.-C-Use-less-stack-space-in-avro_file_write.patch
>
>
> The avro_file_writer code in the C bindings allocate a large (64K) buffer on the stack. This causes (very) hard-to-diagnose bugs if you try to output a data file from within a function with limited stack space. (For instance, if you're running inside of a coroutine or thread with a 64K stack...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1048) C data file writer uses too much
stack space
Posted by "Bruce Mitchener (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236136#comment-13236136 ]
Bruce Mitchener commented on AVRO-1048:
---------------------------------------
+1, lgtm.
> C data file writer uses too much stack space
> --------------------------------------------
>
> Key: AVRO-1048
> URL: https://issues.apache.org/jira/browse/AVRO-1048
> Project: Avro
> Issue Type: Bug
> Components: c
> Affects Versions: 1.6.3
> Reporter: Douglas Creager
> Assignee: Douglas Creager
> Attachments: 0001-AVRO-1048.-C-Use-less-stack-space-in-avro_file_write.patch
>
>
> The avro_file_writer code in the C bindings allocate a large (64K) buffer on the stack. This causes (very) hard-to-diagnose bugs if you try to output a data file from within a function with limited stack space. (For instance, if you're running inside of a coroutine or thread with a 64K stack...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira