You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/11/15 13:03:28 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request #2718: Fix nrf534 ipc with old boot
kasjer opened a new pull request #2718:
URL: https://github.com/apache/mynewt-core/pull/2718
IPC and virtual flash configuration was changed to be TrustZone non-secure friendly.
Those modification broke compatibility with existing net core bootloader.
This restores compatibility with old bootloader.
To enable old bootloader compatibility app core application have to be compiled with
`IPC_NRF5340_PRE_TRUSTZONE_NETCORE_BOOT: 1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer commented on pull request #2718: Fix nrf534 ipc with old boot
Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #2718:
URL: https://github.com/apache/mynewt-core/pull/2718#issuecomment-973992723
Just one commit after rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] t3zeng commented on a change in pull request #2718: Fix nrf534 ipc with old boot
Posted by GitBox <gi...@apache.org>.
t3zeng commented on a change in pull request #2718:
URL: https://github.com/apache/mynewt-core/pull/2718#discussion_r749400308
##########
File path: hw/drivers/ipc_nrf5340/syscfg.yml
##########
@@ -48,6 +48,17 @@ syscfg.defs:
eg "LED_1, LED_2" or "1, 2". Further GPIO configuration should be
done by Network Core.
value: ""
+ IPC_NRF5340_PRE_TRUSTZONE_NETCORE_BOOT:
+ description: >
+ Set this to one only in case of the bootloader predates TrustZone
+ changes. With ARM TrusZone support added NRF_IPC_NS block is used
+ for both secure and non-secure application. Pre-TrustZone code
+ was always running in secure mode and network core code always
+ accessed NRF_IP_S (including code that is running in bootloader).
+ NRF_IP_S->GPMEM[] was used to pass address of net core application
+ image to net bootloader.
+ value: 0
syscfg.restrictions:
- "!BSP_NRF5340 || BSP_NRF5340_NET_ENABLE"
+ - "!IPC_NRF5340_PRE_TRUSTZONE_NETCORE_BOOT || MCU_APP_SECURE"
Review comment:
Given that `MCU_APP_SECURE` is undefined on the netcore side, you would hit this restriction if you set `IPC_NRF5340_PRE_TRUSTZONE_NETCORE_BOOT` to 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2718: Fix nrf534 ipc with old boot
Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2718:
URL: https://github.com/apache/mynewt-core/pull/2718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] t3zeng commented on pull request #2718: Fix nrf534 ipc with old boot
Posted by GitBox <gi...@apache.org>.
t3zeng commented on pull request #2718:
URL: https://github.com/apache/mynewt-core/pull/2718#issuecomment-970611614
Tried this branch on nrf5340 hw and the `IPC_NRF5340_PRE_TRUSTZONE_NETCORE_BOOT` works as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org